Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename readthedocs file #17718

Merged
merged 2 commits into from
Oct 23, 2018
Merged

Rename readthedocs file #17718

merged 2 commits into from
Oct 23, 2018

Conversation

fabaff
Copy link
Member

@fabaff fabaff commented Oct 23, 2018

Description:

The new configuration was introduced with #17642. This change rename the file to make it more clear that's a configuration file.

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass

@homeassistant homeassistant added cla-signed small-pr PRs with less than 30 lines. labels Oct 23, 2018
@ghost ghost assigned fabaff Oct 23, 2018
@ghost ghost added the in progress label Oct 23, 2018
@MartinHjelmare MartinHjelmare changed the title Rename file Rename readthedocs file Oct 23, 2018
@balloob
Copy link
Member

balloob commented Oct 23, 2018

Is this format supported?

@rohankapoorcom
Copy link
Member

rohankapoorcom commented Oct 23, 2018

Doesn't look it, per the docs, it must be readthedocs.yml in the root of the project.

However, the regex they are using does allow the filename to have a dot prefix. I tested the regex really fast and it does validate the proposed file name.

@balloob balloob merged commit f997369 into dev Oct 23, 2018
@ghost ghost removed the in progress label Oct 23, 2018
@balloob balloob deleted the rtd branch October 23, 2018 15:39
@balloob balloob mentioned this pull request Nov 9, 2018
@home-assistant home-assistant locked and limited conversation to collaborators Feb 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-signed Hacktoberfest small-pr PRs with less than 30 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants