Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow manual smlight user setup to override discovery #137136

Merged
merged 7 commits into from
Feb 2, 2025

Conversation

tl-sl
Copy link
Contributor

@tl-sl tl-sl commented Feb 1, 2025

Proposed change

Fix error that occures when user tries to complete manual setup of device that was already discovered.

Can this please be picked for 2025.2

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@tl-sl tl-sl force-pushed the override-discovery branch from 308d921 to 71edb4a Compare February 2, 2025 12:18
@home-assistant home-assistant bot marked this pull request as draft February 2, 2025 13:10
@home-assistant
Copy link

home-assistant bot commented Feb 2, 2025

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@bdraco bdraco marked this pull request as ready for review February 2, 2025 15:46
@home-assistant home-assistant bot requested a review from zweckj February 2, 2025 15:46
@bdraco
Copy link
Member

bdraco commented Feb 2, 2025

sorry, need to fix my dirty local copy which has pysmlight checked out so it thinks it first party

@bdraco bdraco changed the title Allow manual user setup to override discovery Allow manual smlight user setup to override discovery Feb 2, 2025
@bdraco bdraco merged commit a981096 into home-assistant:dev Feb 2, 2025
32 checks passed
zxdavb pushed a commit to zxdavb/hass that referenced this pull request Feb 2, 2025
balloob pushed a commit that referenced this pull request Feb 3, 2025
lboue pushed a commit to lboue/ha_core that referenced this pull request Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot add SLZB-06M with a fqdn, only with the mcast DNS name
4 participants