-
-
Notifications
You must be signed in to change notification settings - Fork 32.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow manual smlight user setup to override discovery #137136
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
home-assistant
bot
added
bugfix
cla-signed
has-tests
integration: smlight
small-pr
PRs with less than 30 lines.
by-code-owner
Quality Scale: No score
labels
Feb 1, 2025
tl-sl
force-pushed
the
override-discovery
branch
from
February 2, 2025 12:18
308d921
to
71edb4a
Compare
zweckj
requested changes
Feb 2, 2025
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
bdraco
approved these changes
Feb 2, 2025
zweckj
approved these changes
Feb 2, 2025
sorry, need to fix my dirty local copy which has pysmlight checked out so it thinks it first party |
bdraco
changed the title
Allow manual user setup to override discovery
Allow manual smlight user setup to override discovery
Feb 2, 2025
zxdavb
pushed a commit
to zxdavb/hass
that referenced
this pull request
Feb 2, 2025
…#137136) Co-authored-by: J. Nick Koston <[email protected]>
balloob
pushed a commit
that referenced
this pull request
Feb 3, 2025
Co-authored-by: J. Nick Koston <[email protected]>
lboue
pushed a commit
to lboue/ha_core
that referenced
this pull request
Feb 3, 2025
…#137136) Co-authored-by: J. Nick Koston <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bugfix
by-code-owner
cherry-picked
cla-signed
has-tests
integration: smlight
Quality Scale: No score
small-pr
PRs with less than 30 lines.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Fix error that occures when user tries to complete manual setup of device that was already discovered.
Can this please be picked for 2025.2
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
.To help with the load of incoming pull requests: