Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow ignored govee-ble devices to be set up from the user flow #137052

Merged
merged 5 commits into from
Feb 1, 2025
Merged

Allow ignored govee-ble devices to be set up from the user flow #137052

merged 5 commits into from
Feb 1, 2025

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Feb 1, 2025 •
edited
Loading

Proposed change

Every few days we get an issue report about a device a user ignored and forgot about, and than can no longer get set up. Sometimes its a govee device, sometimes its a switchbot device, but the pattern is consistent.

Allow ignored devices to be selected in the user step and replace the ignored entry.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@bdraco
Allow ignored govee-ble devices to be setup up from the user flow
50256a4 
Every few days we get an issue report about a device
a user ignored and forgot about, and than can no longer
get set up. Allow ignored devices to be selected in
the user step and replace the ignored entry.
@bdraco bdraco changed the title Allow ignored govee-ble devices to be setup up from the user flow Allow ignored govee-ble devices to be set up from the user flow Feb 1, 2025
@bdraco bdraco marked this pull request as ready for review February 1, 2025 02:21
@bdraco bdraco added this to the 2025.2.0 milestone Feb 1, 2025
@balloob balloob merged commit 84e15e1 into dev Feb 1, 2025
32 checks passed
@balloob balloob deleted the govee_ignore branch February 1, 2025 02:24
@bdraco bdraco mentioned this pull request Feb 1, 2025
Merged
19 tasks
balloob pushed a commit that referenced this pull request Feb 1, 2025
@bdraco @balloob
Allow ignored govee-ble devices to be set up from the user flow (#137052
3a11e8d 
)

* Allow ignored govee-ble devices to be setup up from the user flow

Every few days we get an issue report about a device
a user ignored and forgot about, and than can no longer
get set up. Allow ignored devices to be selected in
the user step and replace the ignored entry.

* Add the ability to skip ignored config entries when calling _abort_if_unique_id_configured

see #137052

* coverage

* revert
bdraco added a commit that referenced this pull request Feb 1, 2025
@bdraco
Allow ignored airthings_ble devices to be set up from the user flow
3334ba4 
Every few days we get an issue report about a device a user ignored and forgot about, and than can no longer get set up. Sometimes its a govee device, sometimes its a switchbot device, but the pattern is consistent.

Allow ignored devices to be selected in the user step and replace the ignored entry.

Same as #137056 and #137052 but for airthings
@bdraco bdraco mentioned this pull request Feb 1, 2025
Merged
19 tasks
bdraco added a commit that referenced this pull request Feb 1, 2025
@bdraco
Allow ignored yale_ble devices to be set up from the user flow
e0e80bd 
Every few days we get an issue report about a device a user ignored and forgot about, and than can no longer get set up. Sometimes its a govee device, sometimes its a switchbot device, but the pattern is consistent.

Allow ignored devices to be selected in the user step and replace the ignored entry.

Same as #137056 and #137052 but for yalexs_ble
@bdraco bdraco mentioned this pull request Feb 1, 2025
Merged
19 tasks
bdraco added a commit that referenced this pull request Feb 1, 2025
@bdraco
Allow ignored thermopro devices to be set up from the user flow
59b507a 
Every few days we get an issue report about a device a user ignored and forgot about, and than can no longer get set up. Sometimes its a govee device, sometimes its a switchbot device, but the pattern is consistent.

Allow ignored devices to be selected in the user step and replace the ignored entry.

Same as #137056 and #137052 but for thermopro
@bdraco bdraco mentioned this pull request Feb 1, 2025
Merged
19 tasks
bdraco added a commit that referenced this pull request Feb 1, 2025
@bdraco
Allow ignored bthome devices to be set up from the user flow
48abea5 
Every few days we get an issue report about a device a user ignored and forgot about, and than can no longer get set up. Sometimes its a govee device, sometimes its a switchbot device, but the pattern is consistent.

Allow ignored devices to be selected in the user step and replace the ignored entry.

Same as #137056 and #137052 but for bthome
@bdraco bdraco mentioned this pull request Feb 1, 2025
Merged
19 tasks
bdraco added a commit that referenced this pull request Feb 1, 2025
@bdraco
Allow ignored mopeka devices to be set up from the user flow
08f93f9 
Every few days we get an issue report about a device a user ignored and forgot about, and than can no longer get set up. Sometimes its a govee device, sometimes its a switchbot device, but the pattern is consistent.

Allow ignored devices to be selected in the user step and replace the ignored entry.

Same as #137056 and #137052 but for mopeka
@bdraco bdraco mentioned this pull request Feb 1, 2025
Merged
19 tasks
bdraco added a commit that referenced this pull request Feb 1, 2025
@bdraco
Allow ignored oralb devices to be set up from the user flow
9ae9949 
Every few days we get an issue report about a device a user ignored and forgot about, and than can no longer get set up. Sometimes its a govee device, sometimes its a switchbot device, but the pattern is consistent.

Allow ignored devices to be selected in the user step and replace the ignored entry.

Same as #137056 and #137052 but for oralb
@bdraco bdraco mentioned this pull request Feb 1, 2025
Merged
19 tasks
bdraco added a commit that referenced this pull request Feb 1, 2025
@bdraco
Allow ignored qingping devices to be set up from the user flow
c0559fd 
Every few days we get an issue report about a device a user ignored and forgot about, and than can no longer get set up. Sometimes its a govee device, sometimes its a switchbot device, but the pattern is consistent.

Allow ignored devices to be selected in the user step and replace the ignored entry.

Same as #137056 and #137052 but for qingping
@bdraco bdraco mentioned this pull request Feb 1, 2025
Merged
19 tasks
bdraco added a commit that referenced this pull request Feb 1, 2025
@bdraco
Allow ignored sensorpush devices to be set up from the user flow
cb5b7b0 
Every few days we get an issue report about a device a user ignored and forgot about, and than can no longer get set up. Sometimes its a govee device, sometimes its a switchbot device, but the pattern is consistent.

Allow ignored devices to be selected in the user step and replace the ignored entry.

Same as #137056 and #137052 but for sensorpush
This was referenced Feb 1, 2025
Merged
Open
bdraco added a commit that referenced this pull request Feb 1, 2025
@bdraco
Allow ignored xiaomi_ble devices to be set up from the user flow
20a89bc 
Every few days we get an issue report about a device a user ignored and forgot about, and than can no longer get set up. Sometimes its a govee device, sometimes its a switchbot device, but the pattern is consistent.

Allow ignored devices to be selected in the user step and replace the ignored entry.

Same as #137056 and #137052 but for xiaomi_ble
@bdraco bdraco mentioned this pull request Feb 1, 2025
Merged
19 tasks
thecode pushed a commit that referenced this pull request Feb 1, 2025
@bdraco
Allow ignored sensorpush devices to be set up from the user flow (#13…
5967957 
…7113)

Every few days we get an issue report about a device a user ignored and forgot about, and than can no longer get set up. Sometimes its a govee device, sometimes its a switchbot device, but the pattern is consistent.

Allow ignored devices to be selected in the user step and replace the ignored entry.

Same as #137056 and #137052 but for sensorpush
bdraco added a commit that referenced this pull request Feb 1, 2025
@bdraco
Allow ignored qingping devices to be set up from the user flow (#137111)
ced52f6 
Every few days we get an issue report about a device a user ignored and forgot about, and than can no longer get set up. Sometimes its a govee device, sometimes its a switchbot device, but the pattern is consistent.

Allow ignored devices to be selected in the user step and replace the ignored entry.

Same as #137056 and #137052 but for qingping
thecode pushed a commit that referenced this pull request Feb 1, 2025
@bdraco
Allow ignored oralb devices to be set up from the user flow (#137109)
bfb9de4 
Every few days we get an issue report about a device a user ignored and forgot about, and than can no longer get set up. Sometimes its a govee device, sometimes its a switchbot device, but the pattern is consistent.

Allow ignored devices to be selected in the user step and replace the ignored entry.

Same as #137056 and #137052 but for oralb
thecode pushed a commit that referenced this pull request Feb 1, 2025
@bdraco
Allow ignored mopeka devices to be set up from the user flow (#137107)
caaa7de 
Every few days we get an issue report about a device a user ignored and forgot about, and than can no longer get set up. Sometimes its a govee device, sometimes its a switchbot device, but the pattern is consistent.

Allow ignored devices to be selected in the user step and replace the ignored entry.

Same as #137056 and #137052 but for mopeka
thecode pushed a commit that referenced this pull request Feb 1, 2025
@bdraco
Allow ignored inkbird devices to be set up from the user flow (#137106)
d28a425 
Every few days we get an issue report about a device a user ignored and forgot about, and than can no longer get set up. Sometimes its a govee device, sometimes its a switchbot device, but the pattern is consistent.

Allow ignored devices to be selected in the user step and replace the ignored entry.

Same as #137056 and #137052 but for inkbird
thecode pushed a commit that referenced this pull request Feb 1, 2025
@bdraco
Allow ignored thermopro devices to be set up from the user flow (#137104
9f85756 
)

Every few days we get an issue report about a device a user ignored and forgot about, and than can no longer get set up. Sometimes its a govee device, sometimes its a switchbot device, but the pattern is consistent.

Allow ignored devices to be selected in the user step and replace the ignored entry.

Same as #137056 and #137052 but for thermopro
thecode pushed a commit that referenced this pull request Feb 1, 2025
@bdraco
Allow ignored yale_ble devices to be set up from the user flow (#137103)
d402166 
Every few days we get an issue report about a device a user ignored and forgot about, and than can no longer get set up. Sometimes its a govee device, sometimes its a switchbot device, but the pattern is consistent.

Allow ignored devices to be selected in the user step and replace the ignored entry.

Same as #137056 and #137052 but for yalexs_ble
thecode pushed a commit that referenced this pull request Feb 1, 2025
@bdraco
Allow ignored airthings_ble devices to be set up from the user flow (#…
3b69a2b 
…137102)

Every few days we get an issue report about a device a user ignored and forgot about, and than can no longer get set up. Sometimes its a govee device, sometimes its a switchbot device, but the pattern is consistent.

Allow ignored devices to be selected in the user step and replace the ignored entry.

Same as #137056 and #137052 but for airthings
@thecode thecode mentioned this pull request Feb 1, 2025
Merged
19 tasks
balloob pushed a commit that referenced this pull request Feb 2, 2025
@bdraco @balloob
Allow ignored airthings_ble devices to be set up from the user flow (#…
bad966f 
…137102)

Every few days we get an issue report about a device a user ignored and forgot about, and than can no longer get set up. Sometimes its a govee device, sometimes its a switchbot device, but the pattern is consistent.

Allow ignored devices to be selected in the user step and replace the ignored entry.

Same as #137056 and #137052 but for airthings
balloob pushed a commit that referenced this pull request Feb 2, 2025
@bdraco @balloob
Allow ignored yale_ble devices to be set up from the user flow (#137103)
7693754 
Every few days we get an issue report about a device a user ignored and forgot about, and than can no longer get set up. Sometimes its a govee device, sometimes its a switchbot device, but the pattern is consistent.

Allow ignored devices to be selected in the user step and replace the ignored entry.

Same as #137056 and #137052 but for yalexs_ble
balloob pushed a commit that referenced this pull request Feb 2, 2025
@bdraco @balloob
Allow ignored thermopro devices to be set up from the user flow (#137104
9b5c215 
)

Every few days we get an issue report about a device a user ignored and forgot about, and than can no longer get set up. Sometimes its a govee device, sometimes its a switchbot device, but the pattern is consistent.

Allow ignored devices to be selected in the user step and replace the ignored entry.

Same as #137056 and #137052 but for thermopro
balloob pushed a commit that referenced this pull request Feb 2, 2025
@bdraco @balloob
Allow ignored inkbird devices to be set up from the user flow (#137106)
cb4b7e7 
Every few days we get an issue report about a device a user ignored and forgot about, and than can no longer get set up. Sometimes its a govee device, sometimes its a switchbot device, but the pattern is consistent.

Allow ignored devices to be selected in the user step and replace the ignored entry.

Same as #137056 and #137052 but for inkbird
balloob pushed a commit that referenced this pull request Feb 2, 2025
@bdraco @balloob
Allow ignored mopeka devices to be set up from the user flow (#137107)
434a4eb 
Every few days we get an issue report about a device a user ignored and forgot about, and than can no longer get set up. Sometimes its a govee device, sometimes its a switchbot device, but the pattern is consistent.

Allow ignored devices to be selected in the user step and replace the ignored entry.

Same as #137056 and #137052 but for mopeka
balloob pushed a commit that referenced this pull request Feb 2, 2025
@bdraco @balloob
Allow ignored oralb devices to be set up from the user flow (#137109)
3b67dc3 
Every few days we get an issue report about a device a user ignored and forgot about, and than can no longer get set up. Sometimes its a govee device, sometimes its a switchbot device, but the pattern is consistent.

Allow ignored devices to be selected in the user step and replace the ignored entry.

Same as #137056 and #137052 but for oralb
balloob pushed a commit that referenced this pull request Feb 2, 2025
@bdraco @balloob
Allow ignored qingping devices to be set up from the user flow (#137111)
63bd67f 
Every few days we get an issue report about a device a user ignored and forgot about, and than can no longer get set up. Sometimes its a govee device, sometimes its a switchbot device, but the pattern is consistent.

Allow ignored devices to be selected in the user step and replace the ignored entry.

Same as #137056 and #137052 but for qingping
balloob pushed a commit that referenced this pull request Feb 2, 2025
@bdraco @balloob
Allow ignored sensorpush devices to be set up from the user flow (#13…
4c8f716 
…7113)

Every few days we get an issue report about a device a user ignored and forgot about, and than can no longer get set up. Sometimes its a govee device, sometimes its a switchbot device, but the pattern is consistent.

Allow ignored devices to be selected in the user step and replace the ignored entry.

Same as #137056 and #137052 but for sensorpush
@github-actions github-actions bot locked and limited conversation to collaborators Feb 2, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@balloob balloob balloob approved these changes

Assignees
No one assigned
Labels
by-code-owner cherry-picked cla-signed code-quality core integration: govee_ble Quality Scale: No score small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
2025.2.0
Development

Successfully merging this pull request may close these issues.

Govee H5179 Not Detecting all Govee Bluetooth Objects
2 participants
@bdraco @balloob