Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump opower to 0.8.9 #136911

Merged
merged 2 commits into from
Jan 31, 2025
Merged

Bump opower to 0.8.9 #136911

merged 2 commits into from
Jan 31, 2025

Conversation

tronikos
Copy link
Member

@tronikos tronikos commented Jan 30, 2025

Breaking change

Proposed change

tronikos/opower@v0.8.8...v0.8.9
Because the library bump is a "breaking change" I had to change handling the exceptions in the same PR.
And because I added py.typed in the library, I had to fix mypy

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@thecode
Copy link
Member

thecode commented Jan 30, 2025

@tronikos can you fix the mypy failures?

Error: homeassistant/components/opower/sensor.py:100: error: Argument "value_fn" to "OpowerEntityDescription" has incompatible type "Callable[[Forecast], date]"; expected "Callable[[Forecast], str | float]"  [arg-type]
Error: homeassistant/components/opower/sensor.py:100: error: Incompatible return value type (got "date", expected "str | float")  [return-value]
Error: homeassistant/components/opower/sensor.py:108: error: Argument "value_fn" to "OpowerEntityDescription" has incompatible type "Callable[[Forecast], date]"; expected "Callable[[Forecast], str | float]"  [arg-type]
Error: homeassistant/components/opower/sensor.py:108: error: Incompatible return value type (got "date", expected "str | float")  [return-value]
Error: homeassistant/components/opower/sensor.py:172: error: Argument "value_fn" to "OpowerEntityDescription" has incompatible type "Callable[[Forecast], date]"; expected "Callable[[Forecast], str | float]"  [arg-type]
Error: homeassistant/components/opower/sensor.py:172: error: Incompatible return value type (got "date", expected "str | float")  [return-value]
Error: homeassistant/components/opower/sensor.py:180: error: Argument "value_fn" to "OpowerEntityDescription" has incompatible type "Callable[[Forecast], date]"; expected "Callable[[Forecast], str | float]"  [arg-type]
Error: homeassistant/components/opower/sensor.py:180: error: Incompatible return value type (got "date", expected "str | float")  [return-value]

@zweckj zweckj marked this pull request as draft January 30, 2025 19:46
@tronikos tronikos marked this pull request as ready for review January 31, 2025 06:52
@tronikos
Copy link
Member Author

Merging because the failure is in unrelated tests/components/airtouch5/test_cover.py

@tronikos tronikos merged commit 99e307f into home-assistant:dev Jan 31, 2025
41 of 42 checks passed
@tronikos tronikos deleted the opower_apiexception branch January 31, 2025 07:34
balloob pushed a commit that referenced this pull request Jan 31, 2025
* Bump opower to 0.8.9

* mypy
@github-actions github-actions bot locked and limited conversation to collaborators Feb 1, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No AMI UtilityAccounts found
4 participants