Include the redirect URL in the Google Drive instructions #136906
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
home-assistant
bot
added
bugfix
cla-signed
core
integration: google_drive
small-pr
19 tasks
MartinHjelmare
requested changes
Jan 30, 2025
There was a problem hiding this comment.
Thanks! I think we can update the docs example with this new function.
https://developers.home-assistant.io/docs/core/platform/application_credentials/#translations
homeassistant/components/google_drive/application_credentials.py
Outdated
Show resolved
Hide resolved
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
Co-authored-by: Martin Hjelmare <[email protected]>
MartinHjelmare
approved these changes
Jan 30, 2025
5 tasks
allenporter
approved these changes
Jan 30, 2025
MartinHjelmare
previously requested changes
Jan 30, 2025
tronikos
dismissed
MartinHjelmare’s stale review
Merging based on the previous approval. Lack of existing tests will be addressed in a follow up PR.
19 tasks
balloob
pushed a commit
that referenced
this pull request
Jan 31, 2025
* Include the redirect URL in the Google Drive instructions * Apply suggestions from code review Co-authored-by: Martin Hjelmare <[email protected]> --------- Co-authored-by: Martin Hjelmare <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking change
Proposed change
Include the redirect URL when setting up Google Drive because I've received feedback from 3 different people about the confusion what redirect URL to use. This is an alternative to #136895 that also works when the my integration is disabled.
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: