Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes to the user-facing strings of energenie_power_sockets #136844

Merged
merged 4 commits into from
Jan 31, 2025

Conversation

NoRi2909
Copy link
Contributor

@NoRi2909 NoRi2909 commented Jan 29, 2025

Proposed change

  • remove wrong dashes from name, and sentence-case "devices"
  • change "id" to correct "ID"

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

- shorten the setup flow headline so it does not overlap the (?) button
- remove wrong dashes from name, and sentence-case "devices"
- change "id" to correct "ID"
@home-assistant
Copy link

Hey there @gnumpi, mind taking a look at this pull request as it has been labeled with an integration (energenie_power_sockets) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of energenie_power_sockets can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign energenie_power_sockets Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@joostlek
Copy link
Member

Oh, hassfest isn't in favor of this change

@NoRi2909
Copy link
Contributor Author

NoRi2909 commented Jan 29, 2025

@joostlek Yes, first it complained that I made the title identical to the integration name, now that I removed it we have the next problem …

But currently this also looks wrong in the integration flow:

image

or in English:

image

We should just have "Energenie Power Sockets" here, too.

@joostlek
Copy link
Member

Sounds good

@NoRi2909
Copy link
Contributor Author

NoRi2909 commented Jan 29, 2025

Hassfest tells us

[CONFIG_FLOW] File integrations.json is not up to date. Run python3 -m script.hassfest

I'm afraid that I cannot address this with the tools I have in the web editor, can you take over at this point?

EDIT: I reverted the "title" change in this PR so this part can be merged now.

@joostlek joostlek added this to the 2025.2.0 milestone Jan 31, 2025
@joostlek joostlek merged commit f1c7206 into home-assistant:dev Jan 31, 2025
32 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Feb 1, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants