-
-
Notifications
You must be signed in to change notification settings - Fork 32.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes to the user-facing strings of energenie_power_sockets #136844
Conversation
- shorten the setup flow headline so it does not overlap the (?) button - remove wrong dashes from name, and sentence-case "devices" - change "id" to correct "ID"
Hey there @gnumpi, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
Oh, hassfest isn't in favor of this change |
@joostlek Yes, first it complained that I made the title identical to the integration name, now that I removed it we have the next problem … But currently this also looks wrong in the integration flow: or in English: We should just have "Energenie Power Sockets" here, too. |
Sounds good |
Hassfest tells us
I'm afraid that I cannot address this with the tools I have in the web editor, can you take over at this point? EDIT: I reverted the "title" change in this PR so this part can be merged now. |
Proposed change
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
.To help with the load of incoming pull requests: