Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix referenced objects in script sequences #135499

Conversation

arturpragacz
Copy link
Contributor

Proposed change

Fix referenced objects (entities, devices, areas, etc.) in script internal sequences.

Reported here: https://community.home-assistant.io/t/entities-not-marked-as-used-in-automations-when-part-of-ui-block-of-actions/827705

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@arturpragacz arturpragacz requested a review from a team as a code owner January 13, 2025 09:32
@arturpragacz arturpragacz changed the title Fix referenced in script sequences Fix referenced objects in script sequences Jan 13, 2025
Copy link
Contributor

@edenhaus edenhaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @arturpragacz 👍

@edenhaus edenhaus added this to the 2025.1.3 milestone Jan 13, 2025
@edenhaus edenhaus merged commit b009f11 into home-assistant:dev Jan 13, 2025
64 checks passed
@arturpragacz arturpragacz deleted the helpers/fix-script-referenced-in-sequence branch January 13, 2025 13:24
dotvav pushed a commit to dotvav/home-assistant-core that referenced this pull request Jan 13, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Jan 14, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants