-
-
Notifications
You must be signed in to change notification settings - Fork 32.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace pyhiveapi with pyhive-integration #135482
Conversation
Hey there @Rendili, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
The test seem to be failing for another integration not hive. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @KJonline 👍
Test failures unrelated
Proposed change
Whilst fixing a bug within the package code for TRV's. I stumbled across and issue with my pypi account where I could no longer log in and use it. I had to create a new account and create a new package to continue distributing it. I haven't been able to resolve it with pypi support.
So this PR includes the following:
fix for TRV valves and an error which occurs.
Renaming of the package to allow further publishing.
Pyhass/Pyhiveapi@v0.5.16...v1.0.1
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
.To help with the load of incoming pull requests: