Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace pyhiveapi with pyhive-integration #135482

Merged
merged 1 commit into from
Jan 13, 2025

Conversation

KJonline
Copy link
Contributor

@KJonline KJonline commented Jan 12, 2025

Proposed change

Whilst fixing a bug within the package code for TRV's. I stumbled across and issue with my pypi account where I could no longer log in and use it. I had to create a new account and create a new package to continue distributing it. I haven't been able to resolve it with pypi support.

So this PR includes the following:

fix for TRV valves and an error which occurs.
Renaming of the package to allow further publishing.

Pyhass/Pyhiveapi@v0.5.16...v1.0.1

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Hey there @Rendili, mind taking a look at this pull request as it has been labeled with an integration (hive) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of hive can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign hive Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@KJonline
Copy link
Contributor Author

The test seem to be failing for another integration not hive.

Copy link
Contributor

@erwindouna erwindouna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@edenhaus edenhaus changed the title Hive Fix TRV and update package name Bump pyhive-integration to 1.0.1 Jan 13, 2025
@edenhaus edenhaus changed the title Bump pyhive-integration to 1.0.1 Replace pyhiveapi with pyhive-integration Jan 13, 2025
Copy link
Contributor

@edenhaus edenhaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @KJonline 👍

Test failures unrelated

@edenhaus edenhaus added this to the 2025.1.3 milestone Jan 13, 2025
@edenhaus edenhaus merged commit ac279d9 into home-assistant:dev Jan 13, 2025
60 of 61 checks passed
@KJonline KJonline deleted the update-package-name branch January 13, 2025 09:13
dotvav pushed a commit to dotvav/home-assistant-core that referenced this pull request Jan 13, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Jan 14, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
4 participants