Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gracefully handle webhook unsubscription if error occurs while contacting Withings #134271

Merged
merged 2 commits into from
Jan 17, 2025

Conversation

dcmeglio
Copy link
Contributor

@dcmeglio dcmeglio commented Dec 30, 2024

Proposed change

Reorders code so we don't get into a state where local operations succeed but network operations fail due to network issues.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes 132564
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.

  • Local tests pass. Your PR cannot be merged unless tests pass

  • There is no commented out code in this PR.

  • I have followed the development checklist

  • I have followed the perfect PR recommendations

  • The code has been formatted using Ruff (ruff format homeassistant tests)

  • Tests have been added to verify that the new code works.
    I can't think of a way to test this yet
    If user exposed functionality or configuration variables are added/changed:

  • Documentation added/updated for www.home-assistant.io

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Hey there @joostlek, mind taking a look at this pull request as it has been labeled with an integration (withings) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of withings can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign withings Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@joostlek joostlek added this to the 2025.1.3 milestone Jan 17, 2025
@joostlek joostlek merged commit 5e0bbf6 into home-assistant:dev Jan 17, 2025
34 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jan 18, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Withings Integration Losing Cloud Connection
3 participants