-
-
Notifications
You must be signed in to change notification settings - Fork 32.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fail on templated service data #128555
base: dev
Are you sure you want to change the base?
Fail on templated service data #128555
Conversation
Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
35fbca4
to
807644b
Compare
def _raise_on_templated_service( | ||
domain: str, _service: str, schema: VolDictType | None | ||
) -> None: | ||
if not schema: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's generally better if the caller has the check and we make the parameter non optional. That will save a function call and make the function signature simpler.
926eb9f
to
4c0fcbb
Compare
There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days. |
Proposed change
Templated service data is difficult to use, because when used in automations or scripts, an attempt is made to prematurely render the template.
The workaround is to encapsulate the template in a string: #40241 (comment)
The purpose of this PR is to get an idea of how many services support templated data, and it should not be merged
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
.To help with the load of incoming pull requests: