Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure _bundle_css is added as resource and resolved on baseclass #7691

Merged
merged 3 commits into from
Feb 7, 2025

Conversation

philippjfr
Copy link
Member

This PR introduces two changes to allow resolving the new _bundle_css for ESM components.

Specifically we:

  • Ensure that the bundle CSS is resolved on the baseclass
  • The _bundle_css files are added to the document head.

Copy link

codecov bot commented Feb 7, 2025

Codecov Report

Attention: Patch coverage is 85.71429% with 2 lines in your changes missing coverage. Please review.

Project coverage is 86.77%. Comparing base (8463ff8) to head (d70c840).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
panel/custom.py 85.71% 1 Missing ⚠️
panel/io/resources.py 85.71% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7691      +/-   ##
==========================================
+ Coverage   86.27%   86.77%   +0.49%     
==========================================
  Files         346      346              
  Lines       52464    52473       +9     
==========================================
+ Hits        45263    45533     +270     
+ Misses       7201     6940     -261     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@philippjfr philippjfr enabled auto-merge (squash) February 7, 2025 20:47
@philippjfr philippjfr merged commit fe88d56 into main Feb 7, 2025
18 checks passed
@philippjfr philippjfr deleted the bundle_css_resolve branch February 7, 2025 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant