Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ESM component module resolution #7684

Merged
merged 2 commits into from
Feb 3, 2025
Merged

Conversation

philippjfr
Copy link
Member

Previously we used the Model.name to determine the name of the JS module inside a bundle. However the name seemingly is sometimes overwritten making this approach brittle. Instead we now use the class_name property, which was previously kebab case but is now passed through directly and only transformed into kebab case client-side.

Copy link

codecov bot commented Feb 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.77%. Comparing base (935acd4) to head (56d694e).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7684      +/-   ##
==========================================
+ Coverage   86.76%   86.77%   +0.01%     
==========================================
  Files         346      346              
  Lines       52444    52444              
==========================================
+ Hits        45501    45509       +8     
+ Misses       6943     6935       -8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@philippjfr philippjfr merged commit 101d6d2 into main Feb 3, 2025
15 of 17 checks passed
@philippjfr philippjfr deleted the esm_module_resolution_fix branch February 3, 2025 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant