Skip to content

What to do about pip 19.1 #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jsignell opened this issue Apr 26, 2019 · 3 comments · Fixed by #13
Closed

What to do about pip 19.1 #12

jsignell opened this issue Apr 26, 2019 · 3 comments · Fixed by #13

Comments

@jsignell
Copy link
Contributor

I have been thinking a lot about this since pip broke editable installs yesterday. (https://discuss.python.org/t/pip-19-1-and-installing-in-editable-mode-with-pyproject-toml/1553/5). I thought #11 would solve our problems, but it created new ones, so I wanted to capture what I have thought about so far.

I think there are several options.

  1. Pin to <19.1

    • fine solution if this is temporary
  2. Use the flag every time you pip install with editable: pip install -e . --no-use-pep517

    • PRO: smallest change
    • PRO: stay on latest pip
    • CON: flag is too long to remember
    • CON: flag is controversial and might go away
  3. Switch to using python setup.py develop

    • PRO: get rid of pyproject.toml
    • PRO: does special things that pip doesn't do (build panel models)
    • CON: no good way to specify build-time dependencies
    • CON: conda doesn't recognize as best version when package already in env
@jbednar
Copy link
Contributor

jbednar commented Apr 26, 2019

Sounds utterly miserable. All options are quite bad.

@jsignell
Copy link
Contributor Author

Seems likely that the pip people will revert while they discuss pypa/pip#6449. Given that, I propose that we pin under 19.1 for now and wait to see how things shake out.

@philippjfr
Copy link
Contributor

Sounds like a plan. What a mess that has been.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants