Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
String conversion from decimal (#108) #122
String conversion from decimal (#108) #122
Changes from 9 commits
bb5f382
fb12295
6866965
55f7ffc
5689315
3c7131f
5a106b0
b296df7
cb2c910
df6b926
bd117d9
048efc0
9a76ab7
42313ad
7e0467a
7f61ee9
1d8f726
f4e6c19
84510f7
6e4f914
e25ce45
8420f46
3fc5f08
d6f32f6
8c858a1
078a8e6
2413444
2e6c49f
765b02b
3430ee5
cbdcdcb
38d53f3
ca9a5ea
9518831
ad5ba70
301af32
b5a4906
fb7ceef
4ef03d7
5587dd6
7ff0d8f
5019647
2f0b0b7
dcd75fd
0472e9b
d55274d
82fd325
35d62f2
88226a1
5ff06b0
091c3f9
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add a bit of description what happens inside this method -- what algorithm you're following?
Doesn't have to be a lot, but a brief description.
Also, what does
iv
mean? I associate the term with cryptographic input vector, but this is probably something else?Also, is the unrolled loop really worth it? If there's no tangible gain, I'd prefer to have it in a shorter form
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lol. i think iv originally meant "index value" or something stupid like that.
I've cleaned up the function and added some comments - let me know if it's still unclear
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If >256, we should have a non-nil
err
. Should check thatThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added this