mvMenu: Resetting menu state if it's not open (#2245) #2246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also, restored indentation in draw_menu() - it's much easier to read now.
hoffstadt
approved these changes
Jan 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
name: Pull Request
about: Create a pull request to help us improve
title: mvMenu: Resetting menu state if it's not open (#2245)
assignees: @hoffstadt
Closes #2245
Description:
Added a branch to
DearPyGui::draw_menu()that resets menu state if the menu is not open.Also, restored indentation in
draw_menu()- it's much easier to read now.Concerning Areas:
I'm not sure that the values that
item.state.contextRegionAvailgets are consistent between the opened menu and the closed menu. But, would anyone ever use that property on a menu? So maybe this piece is not much of a concern, after all.