Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix code section processing RegEx #169

Merged
merged 2 commits into from
Jun 8, 2020
Merged

Conversation

guillett
Copy link
Contributor

@guillett guillett commented Jun 8, 2020

Sources:

I gave it a try and I managed to find, what looks like, a working alternative.

Let me know if I can do anything else.

Sources:
* String literals - facebook/react#13781
* Ungreedy RegEx expression - https://stackoverflow.com/a/40908001
Copy link
Owner

@hmsk hmsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your dedicating your time for the current problem ✨
If my suggested codes work for your current trouble, I'm going to deliver as an additional beta release immediately. (I'm now playing with node-html-parser to unblock the root problem btw)

Co-authored-by: Kengo Hamasaki <[email protected]>
@hmsk hmsk merged commit 259e138 into hmsk:master Jun 8, 2020
@hmsk
Copy link
Owner

hmsk commented Jun 8, 2020

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants