DFR-2638 Remove redundant/unnecessary Health Checks (#1899)

* DFR-2638 Remove redundant/unnecessary Health Checks --------- Co-authored-by: AbuSalam22 <[email protected]>
hmcts · Feb 13, 2024 · 8d0e886 · 8d0e886
1 parent 9aee1d0
commit 8d0e886
Show file tree

Hide file tree

Showing 4 changed files with 0 additions and 157 deletions.
diff --git a/...v/hmcts/reform/divorce/orchestration/management/monitoring/health/IdamApiHealthCheck.java b/...v/hmcts/reform/divorce/orchestration/management/monitoring/health/IdamApiHealthCheck.java
diff --git a/.../reform/divorce/orchestration/management/monitoring/health/PaymentServiceHealthCheck.java b/.../reform/divorce/orchestration/management/monitoring/health/PaymentServiceHealthCheck.java
diff --git a/...form/divorce/orchestration/management/monitoring/health/SendLetterServiceHealthCheck.java b/...form/divorce/orchestration/management/monitoring/health/SendLetterServiceHealthCheck.java
diff --git a/src/test/java/uk/gov/hmcts/reform/divorce/orchestration/functionaltest/HealthCheckITest.java b/src/test/java/uk/gov/hmcts/reform/divorce/orchestration/functionaltest/HealthCheckITest.java
@@ -62,9 +62,6 @@ public void givenAllDependenciesAreUp_whenCheckHealth_thenReturnStatusUp() throw
         mockEndpointAndResponse(maintenanceServiceServer, true);
         mockEndpointAndResponse(documentGeneratorServiceServer, true);
         mockEndpointAndResponse(feesAndPaymentsServer, true);
-        mockEndpointAndResponse(idamServer, true);
-        mockEndpointAndResponse(paymentServiceServer, true);
-        mockEndpointAndResponse(sendLetterService, true);
         mockEndpointAndResponse(serviceAuthProviderServer, true);
 
         waitForMockChange();
@@ -82,49 +79,9 @@ public void givenAllDependenciesAreUp_whenCheckHealth_thenReturnStatusUp() throw
             equalTo("UP"));
         assertThat(JsonPath.read(body, "$.components.feesAndPaymentsServiceHealthCheck.status").toString(),
             equalTo("UP"));
-        assertThat(JsonPath.read(body, "$.components.paymentServiceHealthCheck.status").toString(),
-            equalTo("UP"));
         assertThat(JsonPath.read(body, "$.components.serviceAuthProviderHealthCheck.status").toString(),
             equalTo("UP"));
         assertThat(JsonPath.read(body, "$.components.diskSpace.status").toString(), equalTo("UP"));
-
-        assertThat(JsonPath.read(body, "$.components.sendLetterServiceHealthCheck.status").toString(), equalTo("UP"));
-    }
-
-
-    @Test
-    public void givenSendLetterServiceIsDown_whenCheckHealth_thenReturnStatusDown() throws Exception {
-        mockEndpointAndResponse(formatterServiceServer, false);
-        mockEndpointAndResponse(maintenanceServiceServer, true);
-        mockEndpointAndResponse(documentGeneratorServiceServer, true);
-        mockEndpointAndResponse(feesAndPaymentsServer, true);
-        mockEndpointAndResponse(idamServer, true);
-        mockEndpointAndResponse(paymentServiceServer, true);
-        mockEndpointAndResponse(sendLetterService, false);
-        mockEndpointAndResponse(serviceAuthProviderServer, true);
-
-        waitForMockChange();
-
-        HttpResponse response = getHealth();
-        String body = EntityUtils.toString(response.getEntity());
-
-        assertThat(response.getStatusLine().getStatusCode(), equalTo(503));
-        assertThat(JsonPath.read(body, "$.status").toString(), equalTo("DOWN"));
-        assertThat(JsonPath.read(body, "$.components.caseFormatterServiceHealthCheck.status").toString(),
-            equalTo("DOWN"));
-        assertThat(JsonPath.read(body, "$.components.caseMaintenanceServiceHealthCheck.status").toString(),
-            equalTo("UP"));
-        assertThat(JsonPath.read(body, "$.components.documentGeneratorServiceHealthCheck.status").toString(),
-            equalTo("UP"));
-        assertThat(JsonPath.read(body, "$.components.feesAndPaymentsServiceHealthCheck.status").toString(),
-            equalTo("UP"));
-        assertThat(JsonPath.read(body, "$.components.paymentServiceHealthCheck.status").toString(),
-            equalTo("UP"));
-        assertThat(JsonPath.read(body, "$.components.serviceAuthProviderHealthCheck.status").toString(),
-            equalTo("UP"));
-        assertThat(JsonPath.read(body, "$.components.sendLetterServiceHealthCheck.status").toString(),
-            equalTo("DOWN"));
-        assertThat(JsonPath.read(body, "$.components.diskSpace.status").toString(), equalTo("UP"));
     }
 
     @Test
@@ -133,9 +90,6 @@ public void givenCaseFormatterServiceIsDown_whenCheckHealth_thenReturnStatusDown
         mockEndpointAndResponse(maintenanceServiceServer, true);
         mockEndpointAndResponse(documentGeneratorServiceServer, true);
         mockEndpointAndResponse(feesAndPaymentsServer, true);
-        mockEndpointAndResponse(idamServer, true);
-        mockEndpointAndResponse(paymentServiceServer, true);
-        mockEndpointAndResponse(sendLetterService, true);
         mockEndpointAndResponse(serviceAuthProviderServer, true);
 
         waitForMockChange();
@@ -153,8 +107,6 @@ public void givenCaseFormatterServiceIsDown_whenCheckHealth_thenReturnStatusDown
             equalTo("UP"));
         assertThat(JsonPath.read(body, "$.components.feesAndPaymentsServiceHealthCheck.status").toString(),
             equalTo("UP"));
-        assertThat(JsonPath.read(body, "$.components.paymentServiceHealthCheck.status").toString(),
-            equalTo("UP"));
         assertThat(JsonPath.read(body, "$.components.serviceAuthProviderHealthCheck.status").toString(),
             equalTo("UP"));
         assertThat(JsonPath.read(body, "$.components.diskSpace.status").toString(), equalTo("UP"));
@@ -166,9 +118,6 @@ public void givenDocumentGeneratorServiceIsDown_whenCheckHealth_thenReturnStatus
         mockEndpointAndResponse(maintenanceServiceServer, true);
         mockEndpointAndResponse(documentGeneratorServiceServer, false);
         mockEndpointAndResponse(feesAndPaymentsServer, true);
-        mockEndpointAndResponse(idamServer, true);
-        mockEndpointAndResponse(paymentServiceServer, true);
-        mockEndpointAndResponse(sendLetterService, true);
         mockEndpointAndResponse(serviceAuthProviderServer, true);
 
         waitForMockChange();
@@ -186,8 +135,6 @@ public void givenDocumentGeneratorServiceIsDown_whenCheckHealth_thenReturnStatus
             equalTo("DOWN"));
         assertThat(JsonPath.read(body, "$.components.feesAndPaymentsServiceHealthCheck.status").toString(),
             equalTo("UP"));
-        assertThat(JsonPath.read(body, "$.components.paymentServiceHealthCheck.status").toString(),
-            equalTo("UP"));
         assertThat(JsonPath.read(body, "$.components.serviceAuthProviderHealthCheck.status").toString(),
             equalTo("UP"));
         assertThat(JsonPath.read(body, "$.components.diskSpace.status").toString(), equalTo("UP"));
@@ -199,9 +146,6 @@ public void givenCaseMaintenanceServiceIsDown_whenCheckHealth_thenReturnStatusDo
         mockEndpointAndResponse(maintenanceServiceServer, false);
         mockEndpointAndResponse(documentGeneratorServiceServer, true);
         mockEndpointAndResponse(feesAndPaymentsServer, true);
-        mockEndpointAndResponse(idamServer, true);
-        mockEndpointAndResponse(paymentServiceServer, true);
-        mockEndpointAndResponse(sendLetterService, true);
         mockEndpointAndResponse(serviceAuthProviderServer, true);
 
         waitForMockChange();
@@ -219,8 +163,6 @@ public void givenCaseMaintenanceServiceIsDown_whenCheckHealth_thenReturnStatusDo
             equalTo("UP"));
         assertThat(JsonPath.read(body, "$.components.feesAndPaymentsServiceHealthCheck.status").toString(),
             equalTo("UP"));
-        assertThat(JsonPath.read(body, "$.components.paymentServiceHealthCheck.status").toString(),
-            equalTo("UP"));
         assertThat(JsonPath.read(body, "$.components.serviceAuthProviderHealthCheck.status").toString(),
             equalTo("UP"));
         assertThat(JsonPath.read(body, "$.components.diskSpace.status").toString(), equalTo("UP"));
@@ -232,9 +174,6 @@ public void givenFeesAndPaymentsServiceIsDown_whenCheckHealth_thenReturnStatusDo
         mockEndpointAndResponse(maintenanceServiceServer, true);
         mockEndpointAndResponse(documentGeneratorServiceServer, true);
         mockEndpointAndResponse(feesAndPaymentsServer, false);
-        mockEndpointAndResponse(idamServer, true);
-        mockEndpointAndResponse(paymentServiceServer, true);
-        mockEndpointAndResponse(sendLetterService, true);
         mockEndpointAndResponse(serviceAuthProviderServer, true);
 
         waitForMockChange();
@@ -252,41 +191,6 @@ public void givenFeesAndPaymentsServiceIsDown_whenCheckHealth_thenReturnStatusDo
             equalTo("UP"));
         assertThat(JsonPath.read(body, "$.components.feesAndPaymentsServiceHealthCheck.status").toString(),
             equalTo("DOWN"));
-        assertThat(JsonPath.read(body, "$.components.paymentServiceHealthCheck.status").toString(),
-            equalTo("UP"));
-        assertThat(JsonPath.read(body, "$.components.serviceAuthProviderHealthCheck.status").toString(),
-            equalTo("UP"));
-        assertThat(JsonPath.read(body, "$.components.diskSpace.status").toString(), equalTo("UP"));
-    }
-
-    @Test
-    public void givenPaymentServiceIsDown_whenCheckHealth_thenReturnStatusDown() throws Exception {
-        mockEndpointAndResponse(formatterServiceServer, true);
-        mockEndpointAndResponse(maintenanceServiceServer, true);
-        mockEndpointAndResponse(documentGeneratorServiceServer, true);
-        mockEndpointAndResponse(feesAndPaymentsServer, true);
-        mockEndpointAndResponse(idamServer, true);
-        mockEndpointAndResponse(paymentServiceServer, false);
-        mockEndpointAndResponse(sendLetterService, true);
-        mockEndpointAndResponse(serviceAuthProviderServer, true);
-
-        waitForMockChange();
-
-        HttpResponse response = getHealth();
-        String body = EntityUtils.toString(response.getEntity());
-
-        assertThat(response.getStatusLine().getStatusCode(), equalTo(503));
-        assertThat(JsonPath.read(body, "$.status").toString(), equalTo("DOWN"));
-        assertThat(JsonPath.read(body, "$.components.caseFormatterServiceHealthCheck.status").toString(),
-            equalTo("UP"));
-        assertThat(JsonPath.read(body, "$.components.caseMaintenanceServiceHealthCheck.status").toString(),
-            equalTo("UP"));
-        assertThat(JsonPath.read(body, "$.components.documentGeneratorServiceHealthCheck.status").toString(),
-            equalTo("UP"));
-        assertThat(JsonPath.read(body, "$.components.feesAndPaymentsServiceHealthCheck.status").toString(),
-            equalTo("UP"));
-        assertThat(JsonPath.read(body, "$.components.paymentServiceHealthCheck.status").toString(),
-            equalTo("DOWN"));
         assertThat(JsonPath.read(body, "$.components.serviceAuthProviderHealthCheck.status").toString(),
             equalTo("UP"));
         assertThat(JsonPath.read(body, "$.components.diskSpace.status").toString(), equalTo("UP"));
@@ -298,9 +202,6 @@ public void givenServiceAuthIsDown_whenCheckHealth_thenReturnStatusDown() throws
         mockEndpointAndResponse(maintenanceServiceServer, true);
         mockEndpointAndResponse(documentGeneratorServiceServer, true);
         mockEndpointAndResponse(feesAndPaymentsServer, true);
-        mockEndpointAndResponse(idamServer, true);
-        mockEndpointAndResponse(paymentServiceServer, true);
-        mockEndpointAndResponse(sendLetterService, true);
         mockEndpointAndResponse(serviceAuthProviderServer, false);
 
         waitForMockChange();
@@ -318,8 +219,6 @@ public void givenServiceAuthIsDown_whenCheckHealth_thenReturnStatusDown() throws
             equalTo("UP"));
         assertThat(JsonPath.read(body, "$.components.feesAndPaymentsServiceHealthCheck.status").toString(),
             equalTo("UP"));
-        assertThat(JsonPath.read(body, "$.components.paymentServiceHealthCheck.status").toString(),
-            equalTo("UP"));
         assertThat(JsonPath.read(body, "$.components.serviceAuthProviderHealthCheck.status").toString(),
             equalTo("DOWN"));
         assertThat(JsonPath.read(body, "$.components.diskSpace.status").toString(), equalTo("UP"));
@@ -331,9 +230,6 @@ public void givenAllDependenciesAreDown_whenCheckHealth_thenReturnStatusDown() t
         mockEndpointAndResponse(maintenanceServiceServer, false);
         mockEndpointAndResponse(documentGeneratorServiceServer, false);
         mockEndpointAndResponse(feesAndPaymentsServer, false);
-        mockEndpointAndResponse(idamServer, false);
-        mockEndpointAndResponse(paymentServiceServer, false);
-        mockEndpointAndResponse(sendLetterService, true);
         mockEndpointAndResponse(serviceAuthProviderServer, false);
 
         waitForMockChange();
@@ -351,8 +247,6 @@ public void givenAllDependenciesAreDown_whenCheckHealth_thenReturnStatusDown() t
             equalTo("DOWN"));
         assertThat(JsonPath.read(body, "$.components.feesAndPaymentsServiceHealthCheck.status").toString(),
             equalTo("DOWN"));
-        assertThat(JsonPath.read(body, "$.components.paymentServiceHealthCheck.status").toString(),
-            equalTo("DOWN"));
         assertThat(JsonPath.read(body, "$.components.serviceAuthProviderHealthCheck.status").toString(),
             equalTo("DOWN"));
         assertThat(JsonPath.read(body, "$.components.diskSpace.status").toString(), equalTo("UP"));