Feature/sac 287 add family member

app/controllers/people_managers_controller.rb

@@ -21,7 +21,17 @@ def new
 
   def create
     assign_attributes
-    if entry.save
+
+    success = ActiveRecord::Base.transaction do
+      if entry.save
+        yield entry if block_given?
+        true
+      else
+        false
+      end
+    end
+
+    if success
       redirect_to redirect_to_path
     else
       render :new

app/models/people_manager.rb

@@ -49,6 +49,6 @@ def create_paper_trail_versions_for_destroy_event
   end
 
   def assert_manager_is_not_managed
-    errors.add(:base, :manager_and_managed_the_same) if manager&.id == managed&.id
+    errors.add(:manager_id, :manager_and_managed_the_same) if manager&.id == managed&.id
   end
 end

app/views/person/manageds/new.html.haml

@@ -8,6 +8,7 @@
 
 = render layout: 'people_managers/section' do
   = standard_form(entry, url: person_manageds_path(person), html: {class: 'p-2'}) do |f|
+    = f.error_messages
     - if create_managed? && params[:create]
       = render "new_person_fields", f: f
     - else

config/locales/models.youth.de.yml

@@ -84,6 +84,11 @@ de:
           attributes:
             manager_id:
               taken: ist bereits gesetzt.
+          manager_and_managed_the_same: kann sich nicht selber verwalten.
+    models:
+      people_manager:
+        one: Verwalter*in
+        other: Verwalter*innen
 
   activemodel:
     errors:

spec/controllers/person/manageds_controller_spec.rb

@@ -9,5 +9,6 @@
 require_relative 'people_managers_shared_examples'
 
 describe Person::ManagedsController do
+  it_behaves_like 'people_managers#create'
   it_behaves_like 'people_managers#destroy'
 end

spec/controllers/person/managers_controller_spec.rb

@@ -3,11 +3,12 @@
 #  Copyright (c) 2024, Schweizer Alpen-Club. This file is part of
 #  hitobito_sac_cas and licensed under the Affero General Public License version 3
 #  or later. See the COPYING file at the top-level directory or at
-#  https://github.com/hitobito/hitobito_sac_cas
+#  https://github.com/hitobito/hitobito_youth
 
 require 'spec_helper'
 require_relative 'people_managers_shared_examples'
 
 describe Person::ManagersController do
+  it_behaves_like 'people_managers#create'
   it_behaves_like 'people_managers#destroy'
 end

spec/controllers/person/people_managers_shared_examples.rb

@@ -3,10 +3,41 @@
 #  Copyright (c) 2024, Schweizer Alpen-Club. This file is part of
 #  hitobito_sac_cas and licensed under the Affero General Public License version 3
 #  or later. See the COPYING file at the top-level directory or at
-#  https://github.com/hitobito/hitobito_sac_cas
+#  https://github.com/hitobito/hitobito_youth
 
 require 'spec_helper'
 
+shared_examples 'people_managers#create' do
+  controller(described_class) do
+    def create
+      super { |entry| entry.call_on_yielded }
+    end
+  end
+
+  before { sign_in(people(:root)) }
+
+  context '#create' do
+    let(:params) do
+      attr = described_class.assoc == :people_managers ? :manager_id : :managed_id
+      { person_id: people(:bottom_leader).id, people_manager: { attr => people(:bottom_member).id } }
+    end
+
+    it 'yields' do
+      expect_any_instance_of(PeopleManager).to receive(:call_on_yielded)
+
+      expect { post :create, params: params }.to change { PeopleManager.count }.by(1)
+    end
+
+    it 'does not create entry if yielded block raises error' do
+      expect_any_instance_of(PeopleManager).to receive(:call_on_yielded).and_raise(ActiveRecord::Rollback)
+
+      expect { post :create, params: params }.
+        to raise_error('baaad stuff').
+        and not_change { PeopleManager.count }
+    end
+  end
+end
+
 shared_examples 'people_managers#destroy' do
   controller(described_class) do
     def destroy

spec/features/people_managers_spec.rb

@@ -67,7 +67,7 @@ def find_person(name, retries = 0)
     end
   end
 
-  it 'shows validation errors in form' do
+  it 'shows manager validation errors in form' do
     within_turbo_frame do
       person.people_managers.create!(manager: people(:bottom_member))
       click_dropdown('Verwalter*in zuweisen')
@@ -77,6 +77,16 @@ def find_person(name, retries = 0)
     end
   end
 
+  it 'shows managed validation errors in form' do
+    within_turbo_frame do
+      person.people_manageds.create!(managed: people(:bottom_member))
+      click_dropdown('Kind zuweisen')
+      find_person 'Bottom Member'
+      click_on 'Speichern'
+      expect(page).to have_css('.alert-danger', text: 'Verwalter*in ist bereits gesetzt.')
+    end
+  end
+
   context 'without write permission on other persons' do
     let(:person) { current_user }
     let(:current_user) { Fabricate(Group::TopGroup::LocalSecretary.sti_name, group: top_group).person }