Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): migrate to shiki #683

Merged
merged 5 commits into from
Feb 21, 2025

Conversation

harlan-zw
Copy link
Contributor

@harlan-zw harlan-zw commented Feb 14, 2024

Description

The shiki-es dependency is deprecated, so is shikiji. Both have been merged back to Shiki v1.

npm WARN deprecated [email protected]: Please migrate to https://github.com/antfu/shikiji

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • If it's a new feature, provide a convincing reason to add it. Ideally, you should open a suggestion issue first and have it approved before working on it.
  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

Copy link

codesandbox bot commented Feb 14, 2024

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

Copy link

stackblitz bot commented Feb 14, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link

netlify bot commented Feb 14, 2024

Deploy Preview for histoire-examples-svelte3 failed.

Name Link
🔨 Latest commit da451d4
🔍 Latest deploy log https://app.netlify.com/sites/histoire-examples-svelte3/deploys/67b88127b1ebb70008bf1fc8

Copy link

netlify bot commented Feb 14, 2024

Deploy Preview for histoire-controls failed.

Name Link
🔨 Latest commit da451d4
🔍 Latest deploy log https://app.netlify.com/sites/histoire-controls/deploys/67b881277432dc00084bb309

Copy link

netlify bot commented Feb 14, 2024

Deploy Preview for histoire-examples-vue3 failed.

Name Link
🔨 Latest commit da451d4
🔍 Latest deploy log https://app.netlify.com/sites/histoire-examples-vue3/deploys/67b8812718f79600081cfd61

Copy link

netlify bot commented Feb 14, 2024

Deploy Preview for histoire-site failed.

Name Link
🔨 Latest commit da451d4
🔍 Latest deploy log https://app.netlify.com/sites/histoire-site/deploys/67b88127247cf30008ba0d51

@hugoattal hugoattal self-assigned this Feb 21, 2025
Copy link

pkg-pr-new bot commented Feb 21, 2025

Open in Stackblitz

histoire

npm i https://pkg.pr.new/histoire-dev/histoire@683

@histoire/app

npm i https://pkg.pr.new/histoire-dev/histoire/@histoire/app@683

@histoire/controls

npm i https://pkg.pr.new/histoire-dev/histoire/@histoire/controls@683

@histoire/plugin-percy

npm i https://pkg.pr.new/histoire-dev/histoire/@histoire/plugin-percy@683

@histoire/plugin-nuxt

npm i https://pkg.pr.new/histoire-dev/histoire/@histoire/plugin-nuxt@683

@histoire/plugin-screenshot

npm i https://pkg.pr.new/histoire-dev/histoire/@histoire/plugin-screenshot@683

@histoire/plugin-svelte

npm i https://pkg.pr.new/histoire-dev/histoire/@histoire/plugin-svelte@683

@histoire/plugin-vue

npm i https://pkg.pr.new/histoire-dev/histoire/@histoire/plugin-vue@683

@histoire/shared

npm i https://pkg.pr.new/histoire-dev/histoire/@histoire/shared@683

@histoire/vendors

npm i https://pkg.pr.new/histoire-dev/histoire/@histoire/vendors@683

commit: da451d4

@hugoattal hugoattal requested a review from Akryum February 21, 2025 13:39
@Akryum Akryum merged commit 29144b1 into histoire-dev:main Feb 21, 2025
9 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants