fix(cli): add typescript as dependency #993
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add
typescript
as a dependency for@stacks/cli
to avoidError: Cannot find module 'typescript'
when installing and running@stacks/cli
The error occurs because
ts-node
has typescript as apeerDependency
, and peer dependencies are not installed by default in NPM v3-v6. NPM 7 reintroduced the automatic installation of peer dependencies. The issue is no longer present on the latest NPM version.fixes #964 #985
Type of Change
Testing information
Make sure to run the following on NPM versions
<7
. You can use nvm to switch to node<15
, which should come withnpm < 7
packages/cli
npm pack
typescript
is not installed globally (uninstall it if it is)npm i -g stacks-cli-1.3.4.tgz
stx
, it should run correctly without throwingError: Cannot find module 'typescript'