-
Notifications
You must be signed in to change notification settings - Fork 316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add cl helper #1479
chore: add cl helper #1479
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov Report
@@ Coverage Diff @@
## master #1479 +/- ##
==========================================
+ Coverage 65.95% 66.18% +0.23%
==========================================
Files 117 118 +1
Lines 8597 8621 +24
Branches 1898 1899 +1
==========================================
+ Hits 5670 5706 +36
+ Misses 2689 2677 -12
Partials 238 238
... and 2 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just small remarks regarding JSDocs.
I feel like Cl.trueBool
and Cl.falseBool
could almost be omitted (in favor of bool(true|false)
). But I guess it makes sense to have them for completeness.
Co-authored-by: Hugo C <[email protected]>
I sort of agree, I don't like the |
Cl
bundled export #1444summary
Adds a
Cl
bundled export that allows better discovery of clarity methods and less importing.examples
NEW
VS previously
discussion
I'm still in love with the idea to add the type-constructors in uppercase, e.g.
Cl.Int(2)
(lowercaseCl.false
won't works sincefalse
is a keyword) and keep methods lowercase, e.g.Cl.serialize(...)
to add more distinction (and potentially group more methods under a new namespace, similar toBuffer.from
) -- but I realize it could be confusing.. 🤷♂ cc @hugocaillard @lgalabru