Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: payload type assertions #1395

Merged
merged 1 commit into from
Nov 23, 2022
Merged

feat: payload type assertions #1395

merged 1 commit into from
Nov 23, 2022

Conversation

edu-stx
Copy link
Contributor

@edu-stx edu-stx commented Nov 19, 2022

Description

Adds type assertions for the various payload types.

Type of Change

  • New feature
  • Bug fix
  • API reference/documentation update
  • Other

Does this introduce a breaking change?

No

Are documentation updates required?

No

Testing information

Testing doesn't seem necessary for type assertions.

Checklist

  • Code is commented where needed
  • Unit test coverage for new or modified code paths
  • npm run test passes
  • Changelog is updated
  • Tag 1 of @yknl or @zone117x for review

@CLAassistant
Copy link

CLAassistant commented Nov 19, 2022

CLA assistant check
All committers have signed the CLA.

@vercel
Copy link

vercel bot commented Nov 19, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
stacksjs-docs ✅ Ready (Inspect) Visit Preview Nov 19, 2022 at 10:42PM (UTC)

@edu-stx
Copy link
Contributor Author

edu-stx commented Nov 19, 2022

Hi @yknl, created some type assertions that may be helpful. Was looking to use them in intercepted requests in our integration tests for the Hiro Wallet. Let me know if you'd like them added here.

Not sure if the I should update the changelong too, or that's something you automate?

@janniks
Copy link
Collaborator

janniks commented Nov 20, 2022

Thanks 🙏🏻 I will take a look tomorrow Looks great!

@janniks janniks merged commit cdd32e9 into hirosystems:master Nov 23, 2022
@janniks
Copy link
Collaborator

janniks commented Nov 23, 2022

Wonderful addition thanks 🙏

@edu-stx edu-stx deleted the payload-type-assertions branch November 24, 2022 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants