Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add encode / decode messages to support #1232

Merged

Conversation

beguene
Copy link
Contributor

@beguene beguene commented Apr 15, 2022

This adds an encodeMessage, decodeMessage and hashMessage functions to support arbitrary message signing
more details in #1231

cc: @janniks

Checklist

  • Code is commented where needed
  • Unit test coverage for new or modified code paths
  • npm run test passes
  • Changelog is updated
  • Tag 1 of @yknl or @zone117x for review

@vercel
Copy link

vercel bot commented Apr 15, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/blockstack/stacks-js/G3bUphCNGqKfadqhzQPwGxbeUBA6
✅ Preview: https://stacks-js-git-fork-beguene-feat-add-arbitrary-443dad-blockstack.vercel.app

@codecov-commenter
Copy link

codecov-commenter commented Apr 15, 2022

Codecov Report

Merging #1232 (a073768) into master (ade4444) will increase coverage by 0.05%.
The diff coverage is 100.00%.

❗ Current head a073768 differs from pull request most recent head cd444f9. Consider uploading reports for the commit cd444f9 to get more accurate results

@@            Coverage Diff             @@
##           master    #1232      +/-   ##
==========================================
+ Coverage   64.00%   64.06%   +0.05%     
==========================================
  Files         123      124       +1     
  Lines        8574     8588      +14     
  Branches     1818     1818              
==========================================
+ Hits         5488     5502      +14     
  Misses       2978     2978              
  Partials      108      108              
Impacted Files Coverage Δ
packages/encryption/src/messageSignature.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ade4444...cd444f9. Read the comment docs.

@beguene beguene force-pushed the feat/add-arbitrary-message-signing branch from 027bf28 to 8054db0 Compare April 19, 2022 13:41
@vercel
Copy link

vercel bot commented Apr 19, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
stacks-js ✅ Ready (Inspect) Visit Preview Apr 20, 2022 at 11:16AM (UTC)

@beguene beguene force-pushed the feat/add-arbitrary-message-signing branch from a073768 to cd444f9 Compare April 20, 2022 11:16
@janniks janniks merged commit ad300fb into hirosystems:master Apr 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants