Fix winport.pl on newer Perl versions, update README #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using defined in this manner has been deprecated for many versions, but now returns an error in the newest versions of Perl. The README makes no mention of needing XML::LibXML in run the script properly, and despite it being mentioned in the original UnlinkMKV repository, is warranted in being reiterated here.
Using ffmpeg would cause everything to hang-up because of stdout/stderr readings blocking yadda-yadda. Solved by combining the 2, preventing blocking. Also fixes some indentation because I'm nitpicky.
|
Thanks for this, I added a couple comments. After you confirm on those, we're good to merge. (Y) |
|
|
hilts-vaughan
added a commit
that referenced
this pull request
Jun 25, 2015
Fix winport.pl on newer Perl versions, update README
|
Thanks for your change, I'll prepare a new release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using defined in this manner has been deprecated for many versions, but
now returns an error in the newest versions of Perl. The README makes no
mention of needing XML::LibXML in run the script properly, and despite
it being mentioned in the original UnlinkMKV repository, is warranted in
being reiterated here.
This should fix #3