Remove a couple type ignores + cleanup CacheMappingView #657
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A5rocks
commented
Jun 12, 2021
davfsa
reviewed
Jun 13, 2021
davfsa
reviewed
Jun 13, 2021
A5rocks
commented
Jun 20, 2021
davfsa
reviewed
Jun 20, 2021
davfsa
reviewed
Jun 21, 2021
davfsa
reviewed
Jun 21, 2021
davfsa
added
the
waiting for author
Other two type ignores here are pending update of typeshed in mypy: python/typeshed#5473
Co-authored-by: davfsa <[email protected]> Co-authored-by: FasterSpeeding <[email protected]>
A5rocks
force-pushed
the
type-ignores-be-gone
branch
from
6b379a3 to
9d84d55
Compare
Now, this PR follows the convention found elsewhere in the library. (In hikari/api/rest.py)
davfsa
previously approved these changes
Aug 2, 2021
A5rocks
force-pushed
the
type-ignores-be-gone
branch
from
c1b3ebd to
de50d0a
Compare
davfsa
reviewed
Aug 3, 2021
(why isn't mypy warning me about this!!)
A5rocks
force-pushed
the
type-ignores-be-gone
branch
from
45b8e22 to
a9a52a0
Compare
A5rocks
force-pushed
the
type-ignores-be-gone
branch
from
a9a52a0 to
937ad78
Compare
davfsa
previously approved these changes
Aug 5, 2021
davfsa
approved these changes
Aug 6, 2021
FasterSpeeding
approved these changes
Aug 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I really wanted to remove a few of those pesky type ignores, you know? But I may have added more than I removed... Anyways, this PR also contains cache changes as when I asked around about whether I could change some interfaces, I got directed to remove some things instead.
Checklist
noxand all the pipelines have passed.Related issues
None.