Update documentation, maven settings sample file and fix build CS and SB errors #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: guillaume.lambert <[email protected]>
Signed-off-by: guillaume.lambert <[email protected]>
Signed-off-by: guillaume.lambert <[email protected]>
Signed-off-by: guillaume.lambert <[email protected]>
Signed-off-by: guillaume.lambert <[email protected]>
Signed-off-by: guillaume.lambert <[email protected]>
Signed-off-by: guillaume.lambert <[email protected]>
Signed-off-by: guillaume.lambert <[email protected]>
...ient/src/main/java/org/onap/ccsdk/features/sdnr/wt/odlclient/data/NotificationInputBase.java
Show resolved
Hide resolved
...ient/src/main/java/org/onap/ccsdk/features/sdnr/wt/odlclient/data/OdlRpcObjectMapperXml.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello
Thank you for using TransportPCE.
I am proposing this PR to fix current build errors and to reestablish by default checkstyle and SpotBugs enforcement at buildtime.
If neeeded, they can be disabled on demand by simply calling maven with the options " -Dodlparent.spotbugs.skip " and "-Dodlparent.checkstyle.skip" .
I've updated the documentation this way and also the maven settings xml sample file in the tests folder so that the project can be built without touching the local environment.
I fixed or ignored a few non trivial issues pointed by checkstyle and Spotbugs but I am not totally sure these fixes are completely revelant nor they work properly everywhere.
I did not manage to fully test everything yet.
I'll let you check this proposal and adapt it at your convenience.
Hope this helps