Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle overflow for TransactionId timestamp #435

Merged
merged 2 commits into from
Feb 7, 2025
Merged

Conversation

RickyLB
Copy link
Contributor

@RickyLB RickyLB commented Feb 5, 2025

@ramesh-aureus
Copy link

Thanks for the update @RickyLB .

For some reason, im getting errors if i provide branch name while adding the package dependency. Its working fine on the main branch.

Im getting Error like:

Couldn’t update repository submodules:
Submodule 'protobufs' (https://github.com/hashgraph/hedera-services.git) registered for path 'protobufs'

Cloning into '/Users/darkness/Library/Developer/Xcode/DerivedData/Runner-dvtigcgisdkkghcsrzomqcuqdlmc/SourcePackages/checkouts/hiero-sdk-swift/protobufs'...

fatal: remote error: upload-pack: not our ref 97b3b2f72e64c2cf25b8d308cc3d3a0ae3e193ee

fatal: Fetched in submodule path 'protobufs', but it did not contain 97b3b2f72e64c2cf25b8d308cc3d3a0ae3e193ee. Direct fetching of that commit failed.

@RickyLB RickyLB force-pushed the fix/subtract_underflow branch from c867d9d to af431bb Compare February 6, 2025 19:35
@RickyLB RickyLB force-pushed the fix/subtract_underflow branch from af431bb to 123f44d Compare February 6, 2025 23:32
@RickyLB RickyLB marked this pull request as ready for review February 6, 2025 23:49
@RickyLB RickyLB requested review from a team as code owners February 6, 2025 23:49
@RickyLB
Copy link
Contributor Author

RickyLB commented Feb 7, 2025

Hi, @ramesh-aureus. The issue with the submodule and arithmetic should be fixed on this branch now. Let me know if any problems pop up. This PR will be merged soon (after it's approved).

@Ramesh-Giri
Copy link

Thank you so much @RickyLB for the update.. Its working fine now.. I am able to perform transactions. Btw, why was it affecting only me??

@RickyLB RickyLB merged commit fb101ea into main Feb 7, 2025
11 checks passed
@RickyLB RickyLB deleted the fix/subtract_underflow branch February 7, 2025 23:24
@RickyLB
Copy link
Contributor Author

RickyLB commented Feb 8, 2025

Glad it works @Ramesh-Giri. Without being able to reproduce the exact error on my machine, my guess is it had something to do with your device's system timestamp. In the end, I replaced the logic so there wouldn't be an overflow. This fix is included in the 0.35.0 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants