Get rid of most TODOs

Sources/Hedera/Client.swift

@@ -22,10 +22,9 @@ public class Client {
     /// This can be overridden on an individual transaction with `setMaxTransactionFee()`.
     var maxTransactionFee = defaultMaxTransactionFee
 
-    // TODO: once queries are implemented    
-    // /// The maximum payment that can be automatically attached to a query.
-    // /// If this is not set, payments will not be made automatically for queries.
-    // /// This can be overridden for an individual query with `.setPayment()`.
+    /// The maximum payment that can be automatically attached to a query.
+    /// If this is not set, payments will not be made automatically for queries.
+    /// This can be overridden for an individual query with `.setPayment()`.
     var maxQueryPayment: UInt64?
 
     public init(node id: AccountId, address url: String) {
@@ -102,7 +101,6 @@ public class Client {
             .accountId!
     }
 
-    // FIXME: Get `TransactionId` from `TransactionReceipt` once it has one.
     /// Sends `amount` of tiny bar to `recipient`.
     /// - Parameters:
     ///   - recipient: The recipient of the crypto.
@@ -171,7 +169,6 @@ public class Client {
     }
 
     private func channelFor(node: Node) -> Channel {
-        // TODO: what if the node is not on the client?
         if let channel = channels[node.accountId] {
             return channel
         } else {

Sources/Hedera/Date.swift

@@ -54,7 +54,6 @@ extension Date: LosslessStringConvertible {
     }
 }
 
-// TODO: move to its own file?
 extension TimeInterval: ProtoConvertible {
     typealias Proto = Proto_Duration
 

Sources/Hedera/HederaError.swift

@@ -1,4 +1,3 @@
-// TODO: this should probably be an enum instead
 public struct HederaError: Error {
     let message: String
 }

Sources/Hedera/Transaction.swift

@@ -84,7 +84,7 @@ public class Transaction {
                 receiptStatus == Proto_ResponseCodeEnum.ok.rawValue {
                 // throw if the delay will put us over `validDuration`
                 guard let delayUs = getReceiptDelayUs(startTime: startTime, attempt: attempt) else {
-                    throw HederaError(message: "timed out") // TODO: better error message
+                    throw HederaError(message: "timed out")
                 }
 
                 usleep(delayUs)
@@ -103,7 +103,6 @@ public class Transaction {
             * Double.random(in: 0..<Double((1 << attempt)))
 
         // if the next delay will put us past the valid duration we should stop trying
-        // TODO: use the validDuration specified in the transaction
         let validDuration: TimeInterval = 2 * 60
         let expireInstant = startTime.addingTimeInterval(validDuration)
         if Date(timeIntervalSinceNow: delay).compare(expireInstant) == .orderedDescending {
@@ -172,7 +171,6 @@ public class Transaction {
             throw HederaError(message: "node ID for transaction not found in Client")
         }
 
-        // TODO: actually handle error
         do {
             let response = try methodForTransaction(client.grpcClient(for: node))(inner)
             if response.nodeTransactionPrecheckCode == .ok {
@@ -185,11 +183,7 @@ public class Transaction {
         }
     }
 
-    // TODO: public func executeAsync that takes a callback function
-
     public func executeForReceipt() throws -> TransactionReceipt {
         try executeAndWaitFor { $0 }
     }
-
-    // TODO: public func executeForReceiptAsync that takes a callback function
 }

Sources/Hedera/TransactionBuilder.swift

@@ -31,7 +31,6 @@ public class TransactionBuilder {
         return self
     }
 
-    // TODO: should this allow setting a longer duration than max?
     @discardableResult
     public func setTransactionValidDuration(_ duration: TimeInterval) -> Self {
         body.transactionValidDuration = duration.toProto()

Sources/Hedera/TransactionKind.swift

@@ -15,7 +15,6 @@ enum TransactionKind {
     case fileUpdate
     case systemUndelete
     case systemDelete
-    // TODO: Freeze service
     // case freeze
 
     init(_ body: Proto_TransactionBody.OneOf_Data) {

Sources/Hedera/account/AccountInfo.swift

@@ -13,7 +13,6 @@ public struct AccountInfo {
     let receiverSigRequired: Bool
     let expirationTime: Date
     let autoRenewPeriod: TimeInterval
-    // TODO: Claims
 
     init(_ accountInfo: Proto_CryptoGetInfoResponse.AccountInfo) {
         let proxyAccountId: AccountId?

Sources/Hedera/crypto/KeyList.swift

@@ -11,6 +11,15 @@ public final class KeyList: PublicKey {
         super.init()
     }
 
+    init?(_ proto: Proto_KeyList) {
+        guard proto.keys.count > 0 else { return nil }
+        keys = proto.keys.compactMap(PublicKey.fromProto)
+
+        // Don't want to silently throw away keys we don't recognize
+        guard proto.keys.count == keys.count else { return nil }
+        super.init()
+    }
+
     override func toProto() -> Proto_Key {
         var proto = Proto_Key()
         proto.keyList = toProto()

Sources/Hedera/crypto/PublicKey.swift

@@ -21,7 +21,6 @@ public class PublicKey: CustomStringConvertible, CustomDebugStringConvertible {
         case .thresholdKey:
             return ThresholdKey(key)
         case .rsa3072, .ecdsa384, .none:
-            // TODO: implement rsa and ecdsa eventually
             return nil
         }
     }

Sources/Hedera/crypto/ed25519/Ed25519PrivateKey.swift

@@ -4,8 +4,6 @@ let ed25519PrivateKeyPrefix = "302e020100300506032b657004220420"
 let ed25519PrivateKeyLength = 32
 let combinedEd25519KeyLength = 64
 
-// TODO: init using a pem file
-
 public struct Ed25519PrivateKey {
     private let inner: Sign.KeyPair
 

Sources/Hedera/file/FileInfoQuery.swift

@@ -7,14 +7,14 @@ public struct FileInfo {
     let size: UInt64
     let expirationTime: Date
     let deleted: Bool
-    // TODO:
-    // let keys: Ed25519PublicKey[]
+    let keys: KeyList
 
     init(_ info: Proto_FileGetInfoResponse.FileInfo) {
         fileId = FileId(info.fileID)
         size = UInt64(info.size)
         expirationTime = Date(info.expirationTime)
         deleted = info.deleted
+        keys = KeyList(info.keys)!
     }
 }