Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add new nextExchangeRate property to receipt #2727

Merged
merged 5 commits into from
Jan 6, 2025
Merged

feat: add new nextExchangeRate property to receipt #2727

merged 5 commits into from
Jan 6, 2025

Conversation

ivaylonikolov7
Copy link
Contributor

Description:

  • Adds new property nextExchangeRate to TransactionReceipt
  • Populates the nextRate protobuf related properties in from/toBytes
  • fixes unit tests

Fixes #2696

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@ivaylonikolov7 ivaylonikolov7 requested review from a team as code owners December 17, 2024 23:38
@ivaylonikolov7 ivaylonikolov7 changed the title feat: add new JS property feat: add new nextExchangeRate property to receipt Dec 17, 2024
0xivanov
0xivanov reviewed Dec 18, 2024
View reviewed changes
Copy link
Contributor

@0xivanov 0xivanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG, can you add one integration tests that checks if nextExchangeRate is not null from the receipt?

0xivanov
0xivanov approved these changes Dec 19, 2024
View reviewed changes
Copy link
Contributor

@0xivanov 0xivanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jan 6, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
7.9% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

@ivaylonikolov7 ivaylonikolov7 merged commit b5ebc5e into main Jan 6, 2025
13 of 14 checks passed
@ivaylonikolov7 ivaylonikolov7 deleted the feat/new-receipt branch January 6, 2025 12:59
This was referenced Jan 13, 2025
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xivanov 0xivanov 0xivanov approved these changes

@rwalworth rwalworth Awaiting requested review from rwalworth rwalworth was automatically assigned from hashgraph/hedera-sdk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add new property nextExchangeRate in the receipt
2 participants
@ivaylonikolov7 @0xivanov