fix: change FEE_SCHEDULE_FILE_PART_UPLOADED to not show as an error #2537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ivaylo Nikolov <[email protected]>
Signed-off-by: Ivaylo Nikolov <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2537 +/- ##
==========================================
+ Coverage 84.39% 84.41% +0.01%
==========================================
Files 283 283
Lines 71017 71021 +4
==========================================
+ Hits 59938 59951 +13
+ Misses 11079 11070 -9 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Ivaylo Nikolov <[email protected]>
0xivanov
reviewed
Sep 25, 2024
Signed-off-by: Ivaylo Nikolov <[email protected]>
|
This was referenced Oct 7, 2024
b-l-u-e
pushed a commit
to b-l-u-e/hedera-sdk-js
that referenced
this pull request
Oct 13, 2024
…iero-ledger#2537) * fix: change FEE_SCHEDULE_FILE_PART_UPLOADED to not show as an error Signed-off-by: Ivaylo Nikolov <[email protected]> * test: add integration test for fee schedule file Signed-off-by: Ivaylo Nikolov <[email protected]> * refactor(test): add const variable for dummy text Signed-off-by: Ivaylo Nikolov <[email protected]> * chore: reuse finished status Signed-off-by: Ivaylo Nikolov <[email protected]> --------- Signed-off-by: Ivaylo Nikolov <[email protected]> Signed-off-by: b-l-u-e <[email protected]>
b-l-u-e
pushed a commit
to b-l-u-e/hedera-sdk-js
that referenced
this pull request
Oct 13, 2024
…iero-ledger#2537) * fix: change FEE_SCHEDULE_FILE_PART_UPLOADED to not show as an error Signed-off-by: Ivaylo Nikolov <[email protected]> * test: add integration test for fee schedule file Signed-off-by: Ivaylo Nikolov <[email protected]> * refactor(test): add const variable for dummy text Signed-off-by: Ivaylo Nikolov <[email protected]> * chore: reuse finished status Signed-off-by: Ivaylo Nikolov <[email protected]> --------- Signed-off-by: Ivaylo Nikolov <[email protected]> Signed-off-by: b-l-u-e <[email protected]>
This was referenced Nov 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Updates TransactionResponse to not throw ReceiptStatus error and mark the receipt as finished
Related issue(s): #2501
Fixes #2501
Checklist