feat: Token Claim and Cancel Transaction #2499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ivaylo Nikolov <[email protected]>
Signed-off-by: Ivaylo Nikolov <[email protected]>
Signed-off-by: Ivaylo Nikolov <[email protected]>
Signed-off-by: Ivaylo Nikolov <[email protected]>
Signed-off-by: Ivaylo Nikolov <[email protected]>
ivaylonikolov7
changed the base branch from
main
to
feat/tokenairdroptransaction
0xivanov
reviewed
Sep 3, 2024
This was
linked to
issues
Sep 3, 2024
Signed-off-by: Ivaylo Nikolov <[email protected]>
Signed-off-by: Ivaylo Nikolov <[email protected]>
Signed-off-by: Ivaylo Nikolov <[email protected]>
Signed-off-by: Ivaylo Nikolov <[email protected]>
Signed-off-by: Ivaylo Nikolov <[email protected]>
Signed-off-by: Ivaylo Nikolov <[email protected]>
Signed-off-by: Ivaylo Nikolov <[email protected]>
Signed-off-by: Ivaylo Nikolov <[email protected]>
Signed-off-by: Ivaylo Nikolov <[email protected]>
ivaylonikolov7
changed the title
Signed-off-by: Ivaylo Nikolov <[email protected]>
Signed-off-by: Ivaylo Nikolov <[email protected]>
Signed-off-by: Ivaylo Nikolov <[email protected]>
Signed-off-by: Ivaylo Nikolov <[email protected]>
Signed-off-by: Ivaylo Nikolov <[email protected]>
agadzhalov
requested changes
Sep 10, 2024
Signed-off-by: Ivaylo Nikolov <[email protected]>
|
0xivanov
reviewed
Sep 11, 2024
agadzhalov
approved these changes
Sep 11, 2024
ivaylonikolov7
merged commit 7a36f44
into
feat/tokenairdroptransaction
5 of 6 checks passed
ivaylonikolov7
added a commit
that referenced
this pull request
Sep 11, 2024
* feat: add airdrop claim and cancel transactions Signed-off-by: Ivaylo Nikolov <[email protected]> * chore: update protobufs Signed-off-by: Ivaylo Nikolov <[email protected]> * feat: update commit messages Signed-off-by: Ivaylo Nikolov <[email protected]> * test: add unit tests for cancel and claim Signed-off-by: Ivaylo Nikolov <[email protected]> * wip(test): add integration tests for cancel and claim transactions Signed-off-by: Ivaylo Nikolov <[email protected]> * fix: claim used the wrong channel function Signed-off-by: Ivaylo Nikolov <[email protected]> * refactor: rename transaction name Signed-off-by: Ivaylo Nikolov <[email protected]> * refactor: remove claim references in airdropcancel integration test Signed-off-by: Ivaylo Nikolov <[email protected]> * test(fix): fix not working test for airdrop cancel and claim Signed-off-by: Ivaylo Nikolov <[email protected]> * fix: airdropcancel transaction should work on sender not receiver Signed-off-by: Ivaylo Nikolov <[email protected]> * feat: add token airdrop example Signed-off-by: Ivaylo Nikolov <[email protected]> * refactor: rename transactions to have the same name as java Signed-off-by: Ivaylo Nikolov <[email protected]> * refactor: remove redundant imports and empty lines Signed-off-by: Ivaylo Nikolov <[email protected]> * refactor: rename transaction tests to have the same name as java sdk Signed-off-by: Ivaylo Nikolov <[email protected]> * docs: add licenses Signed-off-by: Ivaylo Nikolov <[email protected]> * fix: remove dead code from token cancel Signed-off-by: Ivaylo Nikolov <[email protected]> * refactor: consistency in constructor Signed-off-by: Ivaylo Nikolov <[email protected]> * refactor: change airdrop_supply_per_person naming Signed-off-by: Ivaylo Nikolov <[email protected]> * test: fix setting sender id Signed-off-by: Ivaylo Nikolov <[email protected]> * refactor: specify what kind of tokens are airdropped Signed-off-by: Ivaylo Nikolov <[email protected]> --------- Signed-off-by: Ivaylo Nikolov <[email protected]>
ivaylonikolov7
added a commit
that referenced
this pull request
Sep 12, 2024
* feat: add Airdrop Transaction Signed-off-by: Ivaylo Nikolov <[email protected]> * test(wip): unit tests Signed-off-by: Ivaylo Nikolov <[email protected]> * fix: use interface for AccountAmount protobuf Signed-off-by: Ivaylo Nikolov <[email protected]> * fix: remove circular dependancy Signed-off-by: Ivaylo Nikolov <[email protected]> * refactor: RenameTokenTransfer list to TokenTransfer Signed-off-by: Ivaylo Nikolov <[email protected]> * feat: rename token transfer and add expected decimals Signed-off-by: Ivaylo Nikolov <[email protected]> * refactor: remove redundant code Signed-off-by: Ivaylo Nikolov <[email protected]> * test: finished unit tests Signed-off-by: Ivaylo Nikolov <[email protected]> * fix: correct return type for amount Signed-off-by: Ivaylo Nikolov <[email protected]> * fix: correct return for fromProtobuf Signed-off-by: Ivaylo Nikolov <[email protected]> * feat: add missing methods Signed-off-by: Ivaylo Nikolov <[email protected]> * refactor: use already implemented interfaces and classes Signed-off-by: Ivaylo Nikolov <[email protected]> * refactor: transfer transaction and airdrop transaction Signed-off-by: Ivaylo Nikolov <[email protected]> * feat: add logid and execute Signed-off-by: Ivaylo Nikolov <[email protected]> * feat: add integration tests Signed-off-by: Ivaylo Nikolov <[email protected]> * feat: add pending airdrop to rectord Signed-off-by: Ivaylo Nikolov <[email protected]> * test: add nft transfers to all test cases Signed-off-by: Ivaylo Nikolov <[email protected]> * chore: remove unused files for airdrop Signed-off-by: Ivaylo Nikolov <[email protected]> * refactor: remove circular dependancy and unused import Signed-off-by: Ivaylo Nikolov <[email protected]> * refactor: remove duplicated property Signed-off-by: Ivaylo Nikolov <[email protected]> * refactor: rename pendngairdroprecord Signed-off-by: Ivaylo Nikolov <[email protected]> * refactor: remove unused files Signed-off-by: Ivaylo Nikolov <[email protected]> * refactor: rename AirdropTokenTransaction Signed-off-by: Ivaylo Nikolov <[email protected]> * test: add additional tests Signed-off-by: Ivaylo Nikolov <[email protected]> * fix: rename file reference Signed-off-by: Ivaylo Nikolov <[email protected]> * test: check if newPendingAirdrops is empty for auto associated test Signed-off-by: Ivaylo Nikolov <[email protected]> * refactor: remove comment lines Signed-off-by: Ivaylo Nikolov <[email protected]> * test: remove get receipt line because we call get record Signed-off-by: Ivaylo Nikolov <[email protected]> * test: should be able to airdrop when receiver sig set to true Signed-off-by: Ivaylo Nikolov <[email protected]> * refactor: rename AbstractTokenTransfer Signed-off-by: Ivaylo Nikolov <[email protected]> * feat: Token Claim and Cancel Transaction (#2499) * feat: add airdrop claim and cancel transactions Signed-off-by: Ivaylo Nikolov <[email protected]> * chore: update protobufs Signed-off-by: Ivaylo Nikolov <[email protected]> * feat: update commit messages Signed-off-by: Ivaylo Nikolov <[email protected]> * test: add unit tests for cancel and claim Signed-off-by: Ivaylo Nikolov <[email protected]> * wip(test): add integration tests for cancel and claim transactions Signed-off-by: Ivaylo Nikolov <[email protected]> * fix: claim used the wrong channel function Signed-off-by: Ivaylo Nikolov <[email protected]> * refactor: rename transaction name Signed-off-by: Ivaylo Nikolov <[email protected]> * refactor: remove claim references in airdropcancel integration test Signed-off-by: Ivaylo Nikolov <[email protected]> * test(fix): fix not working test for airdrop cancel and claim Signed-off-by: Ivaylo Nikolov <[email protected]> * fix: airdropcancel transaction should work on sender not receiver Signed-off-by: Ivaylo Nikolov <[email protected]> * feat: add token airdrop example Signed-off-by: Ivaylo Nikolov <[email protected]> * refactor: rename transactions to have the same name as java Signed-off-by: Ivaylo Nikolov <[email protected]> * refactor: remove redundant imports and empty lines Signed-off-by: Ivaylo Nikolov <[email protected]> * refactor: rename transaction tests to have the same name as java sdk Signed-off-by: Ivaylo Nikolov <[email protected]> * docs: add licenses Signed-off-by: Ivaylo Nikolov <[email protected]> * fix: remove dead code from token cancel Signed-off-by: Ivaylo Nikolov <[email protected]> * refactor: consistency in constructor Signed-off-by: Ivaylo Nikolov <[email protected]> * refactor: change airdrop_supply_per_person naming Signed-off-by: Ivaylo Nikolov <[email protected]> * test: fix setting sender id Signed-off-by: Ivaylo Nikolov <[email protected]> * refactor: specify what kind of tokens are airdropped Signed-off-by: Ivaylo Nikolov <[email protected]> --------- Signed-off-by: Ivaylo Nikolov <[email protected]> * fix(test): when empty id should be null Signed-off-by: Ivaylo Nikolov <[email protected]> * refactor: should return always in jsdoc Signed-off-by: Ivaylo Nikolov <[email protected]> --------- Signed-off-by: Ivaylo Nikolov <[email protected]>
ivaylogarnev-limechain
pushed a commit
that referenced
this pull request
Sep 19, 2024
* feat: add Airdrop Transaction Signed-off-by: Ivaylo Nikolov <[email protected]> * test(wip): unit tests Signed-off-by: Ivaylo Nikolov <[email protected]> * fix: use interface for AccountAmount protobuf Signed-off-by: Ivaylo Nikolov <[email protected]> * fix: remove circular dependancy Signed-off-by: Ivaylo Nikolov <[email protected]> * refactor: RenameTokenTransfer list to TokenTransfer Signed-off-by: Ivaylo Nikolov <[email protected]> * feat: rename token transfer and add expected decimals Signed-off-by: Ivaylo Nikolov <[email protected]> * refactor: remove redundant code Signed-off-by: Ivaylo Nikolov <[email protected]> * test: finished unit tests Signed-off-by: Ivaylo Nikolov <[email protected]> * fix: correct return type for amount Signed-off-by: Ivaylo Nikolov <[email protected]> * fix: correct return for fromProtobuf Signed-off-by: Ivaylo Nikolov <[email protected]> * feat: add missing methods Signed-off-by: Ivaylo Nikolov <[email protected]> * refactor: use already implemented interfaces and classes Signed-off-by: Ivaylo Nikolov <[email protected]> * refactor: transfer transaction and airdrop transaction Signed-off-by: Ivaylo Nikolov <[email protected]> * feat: add logid and execute Signed-off-by: Ivaylo Nikolov <[email protected]> * feat: add integration tests Signed-off-by: Ivaylo Nikolov <[email protected]> * feat: add pending airdrop to rectord Signed-off-by: Ivaylo Nikolov <[email protected]> * test: add nft transfers to all test cases Signed-off-by: Ivaylo Nikolov <[email protected]> * chore: remove unused files for airdrop Signed-off-by: Ivaylo Nikolov <[email protected]> * refactor: remove circular dependancy and unused import Signed-off-by: Ivaylo Nikolov <[email protected]> * refactor: remove duplicated property Signed-off-by: Ivaylo Nikolov <[email protected]> * refactor: rename pendngairdroprecord Signed-off-by: Ivaylo Nikolov <[email protected]> * refactor: remove unused files Signed-off-by: Ivaylo Nikolov <[email protected]> * refactor: rename AirdropTokenTransaction Signed-off-by: Ivaylo Nikolov <[email protected]> * test: add additional tests Signed-off-by: Ivaylo Nikolov <[email protected]> * fix: rename file reference Signed-off-by: Ivaylo Nikolov <[email protected]> * test: check if newPendingAirdrops is empty for auto associated test Signed-off-by: Ivaylo Nikolov <[email protected]> * refactor: remove comment lines Signed-off-by: Ivaylo Nikolov <[email protected]> * test: remove get receipt line because we call get record Signed-off-by: Ivaylo Nikolov <[email protected]> * test: should be able to airdrop when receiver sig set to true Signed-off-by: Ivaylo Nikolov <[email protected]> * refactor: rename AbstractTokenTransfer Signed-off-by: Ivaylo Nikolov <[email protected]> * feat: Token Claim and Cancel Transaction (#2499) * feat: add airdrop claim and cancel transactions Signed-off-by: Ivaylo Nikolov <[email protected]> * chore: update protobufs Signed-off-by: Ivaylo Nikolov <[email protected]> * feat: update commit messages Signed-off-by: Ivaylo Nikolov <[email protected]> * test: add unit tests for cancel and claim Signed-off-by: Ivaylo Nikolov <[email protected]> * wip(test): add integration tests for cancel and claim transactions Signed-off-by: Ivaylo Nikolov <[email protected]> * fix: claim used the wrong channel function Signed-off-by: Ivaylo Nikolov <[email protected]> * refactor: rename transaction name Signed-off-by: Ivaylo Nikolov <[email protected]> * refactor: remove claim references in airdropcancel integration test Signed-off-by: Ivaylo Nikolov <[email protected]> * test(fix): fix not working test for airdrop cancel and claim Signed-off-by: Ivaylo Nikolov <[email protected]> * fix: airdropcancel transaction should work on sender not receiver Signed-off-by: Ivaylo Nikolov <[email protected]> * feat: add token airdrop example Signed-off-by: Ivaylo Nikolov <[email protected]> * refactor: rename transactions to have the same name as java Signed-off-by: Ivaylo Nikolov <[email protected]> * refactor: remove redundant imports and empty lines Signed-off-by: Ivaylo Nikolov <[email protected]> * refactor: rename transaction tests to have the same name as java sdk Signed-off-by: Ivaylo Nikolov <[email protected]> * docs: add licenses Signed-off-by: Ivaylo Nikolov <[email protected]> * fix: remove dead code from token cancel Signed-off-by: Ivaylo Nikolov <[email protected]> * refactor: consistency in constructor Signed-off-by: Ivaylo Nikolov <[email protected]> * refactor: change airdrop_supply_per_person naming Signed-off-by: Ivaylo Nikolov <[email protected]> * test: fix setting sender id Signed-off-by: Ivaylo Nikolov <[email protected]> * refactor: specify what kind of tokens are airdropped Signed-off-by: Ivaylo Nikolov <[email protected]> --------- Signed-off-by: Ivaylo Nikolov <[email protected]> * fix(test): when empty id should be null Signed-off-by: Ivaylo Nikolov <[email protected]> * refactor: should return always in jsdoc Signed-off-by: Ivaylo Nikolov <[email protected]> --------- Signed-off-by: Ivaylo Nikolov <[email protected]> Signed-off-by: ivaylogarnev-limechain <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR introduces TokenClaimTransaction and TokenCancelTransaction.
Related issue(s):
#2464 #2466 #2467
Fixes #
#2466 #2467 #2469
Checklist