Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: create node transaction #2402

Conversation

svetoslav-nikol0v
Copy link
Contributor

@svetoslav-nikol0v svetoslav-nikol0v commented Jul 17, 2024

Description:

This is transaction allows to create a new node in the network. Part of HIP-869.

Fixes #2335 #2338 #2339

Notes for reviewer:
Still in progress...

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

Signed-off-by: svetoslav-nikol0v <[email protected]>
Signed-off-by: svetoslav-nikol0v <[email protected]>
Signed-off-by: svetoslav-nikol0v <[email protected]>
Signed-off-by: svetoslav-nikol0v <[email protected]>
@svetoslav-nikol0v svetoslav-nikol0v requested review from a team as code owners July 17, 2024 18:35
Signed-off-by: svetoslav-nikol0v <[email protected]>
Signed-off-by: svetoslav-nikol0v <[email protected]>
@svetoslav-nikol0v svetoslav-nikol0v changed the base branch from main to hip-869-dynamic-address-book July 18, 2024 08:14
Copy link

@svetoslav-nikol0v svetoslav-nikol0v merged commit 2b4b1e7 into hip-869-dynamic-address-book Jul 18, 2024
2 checks passed
@svetoslav-nikol0v svetoslav-nikol0v deleted the 2335-add-hip-869-nodecreatetransaction branch July 18, 2024 12:30
svetoslav-nikol0v added a commit that referenced this pull request Aug 6, 2024
* feat: add addressBook channel

Signed-off-by: svetoslav-nikol0v <[email protected]>

* feat: implement NodeCreateTransaction class

Signed-off-by: svetoslav-nikol0v <[email protected]>

* feat: implement ServiceEndpoint class

Signed-off-by: svetoslav-nikol0v <[email protected]>

* chore: export new classess

Signed-off-by: svetoslav-nikol0v <[email protected]>

* update: proto changes

Signed-off-by: svetoslav-nikol0v <[email protected]>

* update: transaction receipt

Signed-off-by: svetoslav-nikol0v <[email protected]>

* fix: unit tests

Signed-off-by: svetoslav-nikol0v <[email protected]>

* fix: method in node create transaction

Signed-off-by: svetoslav-nikol0v <[email protected]>

---------

Signed-off-by: svetoslav-nikol0v <[email protected]>
ivaylonikolov7 pushed a commit that referenced this pull request Aug 13, 2024
* feat: create node transaction (#2402)

* feat: add addressBook channel

Signed-off-by: svetoslav-nikol0v <[email protected]>

* feat: implement NodeCreateTransaction class

Signed-off-by: svetoslav-nikol0v <[email protected]>

* feat: implement ServiceEndpoint class

Signed-off-by: svetoslav-nikol0v <[email protected]>

* chore: export new classess

Signed-off-by: svetoslav-nikol0v <[email protected]>

* update: proto changes

Signed-off-by: svetoslav-nikol0v <[email protected]>

* update: transaction receipt

Signed-off-by: svetoslav-nikol0v <[email protected]>

* fix: unit tests

Signed-off-by: svetoslav-nikol0v <[email protected]>

* fix: method in node create transaction

Signed-off-by: svetoslav-nikol0v <[email protected]>

---------

Signed-off-by: svetoslav-nikol0v <[email protected]>

* fix: integration test

Signed-off-by: svetoslav-nikol0v <[email protected]>

* chore: remove .only

Signed-off-by: svetoslav-nikol0v <[email protected]>

* feat: node delete transaction (#2404)

Signed-off-by: svetoslav-nikol0v <[email protected]>

* feat: node update transaction (#2405)

* feat: node update transaction

Signed-off-by: svetoslav-nikol0v <[email protected]>

* fix: adjustments

Signed-off-by: svetoslav-nikol0v <[email protected]>

---------

Signed-off-by: svetoslav-nikol0v <[email protected]>

* update: example for HIP-869 (#2443)

* chore: formatting

Signed-off-by: Svet <[email protected]>

* add: example

Signed-off-by: Svet <[email protected]>

* chore: formatting

Signed-off-by: Svet <[email protected]>

* update: example

Signed-off-by: Svet <[email protected]>

---------

Signed-off-by: Svet <[email protected]>

* update: remove default values

Signed-off-by: Svet <[email protected]>

---------

Signed-off-by: svetoslav-nikol0v <[email protected]>
Signed-off-by: Svet <[email protected]>
ivaylogarnev-limechain pushed a commit that referenced this pull request Aug 22, 2024
* feat: create node transaction (#2402)

* feat: add addressBook channel

Signed-off-by: svetoslav-nikol0v <[email protected]>

* feat: implement NodeCreateTransaction class

Signed-off-by: svetoslav-nikol0v <[email protected]>

* feat: implement ServiceEndpoint class

Signed-off-by: svetoslav-nikol0v <[email protected]>

* chore: export new classess

Signed-off-by: svetoslav-nikol0v <[email protected]>

* update: proto changes

Signed-off-by: svetoslav-nikol0v <[email protected]>

* update: transaction receipt

Signed-off-by: svetoslav-nikol0v <[email protected]>

* fix: unit tests

Signed-off-by: svetoslav-nikol0v <[email protected]>

* fix: method in node create transaction

Signed-off-by: svetoslav-nikol0v <[email protected]>

---------

Signed-off-by: svetoslav-nikol0v <[email protected]>

* fix: integration test

Signed-off-by: svetoslav-nikol0v <[email protected]>

* chore: remove .only

Signed-off-by: svetoslav-nikol0v <[email protected]>

* feat: node delete transaction (#2404)

Signed-off-by: svetoslav-nikol0v <[email protected]>

* feat: node update transaction (#2405)

* feat: node update transaction

Signed-off-by: svetoslav-nikol0v <[email protected]>

* fix: adjustments

Signed-off-by: svetoslav-nikol0v <[email protected]>

---------

Signed-off-by: svetoslav-nikol0v <[email protected]>

* update: example for HIP-869 (#2443)

* chore: formatting

Signed-off-by: Svet <[email protected]>

* add: example

Signed-off-by: Svet <[email protected]>

* chore: formatting

Signed-off-by: Svet <[email protected]>

* update: example

Signed-off-by: Svet <[email protected]>

---------

Signed-off-by: Svet <[email protected]>

* update: remove default values

Signed-off-by: Svet <[email protected]>

---------

Signed-off-by: svetoslav-nikol0v <[email protected]>
Signed-off-by: Svet <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants