Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Standardize NftId string format #1258

Merged
merged 1 commit into from
Feb 12, 2025
Merged

chore: Standardize NftId string format #1258

merged 1 commit into from
Feb 12, 2025

Conversation

0xivanov
Copy link
Contributor

Fixes: #1248

@0xivanov 0xivanov self-assigned this Feb 11, 2025
@codecov Codecov
Copy link

codecov bot commented Feb 11, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
sdk/nft_id.go 75.00% 1 Missing ⚠️
Files with missing lines Coverage Δ
sdk/nft_id.go 58.82% <75.00%> (ø)

@0xivanov 0xivanov marked this pull request as ready for review February 12, 2025 09:02
@0xivanov 0xivanov requested review from a team as code owners February 12, 2025 09:02
@0xivanov 0xivanov merged commit 1cd5ef7 into main Feb 12, 2025
7 checks passed
@0xivanov 0xivanov deleted the 1248-standardize-NftId-string-format branch February 12, 2025 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gsstoykov gsstoykov gsstoykov approved these changes

Assignees

@0xivanov 0xivanov

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Standardize NftId string format either tokenid@serial or serial@tokenid across all codebase.
2 participants
@0xivanov @gsstoykov