feat: Remove zero shard and realm assumption #906
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: gsstoykov <[email protected]>
Signed-off-by: gsstoykov <[email protected]>
gsstoykov
changed the title
Signed-off-by: gsstoykov <[email protected]>
Signed-off-by: gsstoykov <[email protected]>
rwalworth
reviewed
Feb 25, 2025
rwalworth
approved these changes
Feb 27, 2025
rwalworth
deleted the
00898-investigate-0-shard-and-realm-assumptions
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
populateAccountEvmnow sets the fullaccountIdfor the mirror node query.zeroAddresscheck is now removed as the assumption for 12 zero bytes would be wrong if there are populated shard and realm values.Related issue(s):
Fixes #898
Notes for reviewer:
Checklist