Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Notify fixes #863

Merged
merged 2 commits into from
Jul 12, 2020
Merged

Notify fixes #863

merged 2 commits into from
Jul 12, 2020

Conversation

steven-sheehy
Copy link
Contributor

@steven-sheehy steven-sheehy commented Jul 11, 2020 •
edited
Loading

Detailed description:

  • Change notify reconnect to use a backoff
  • Change unlisten to active on dispose of EmitterProcessor instead of longer processing chain
  • Fix Hibernate trying to connect on startup to check if embedded database
  • Fix incorrectly using EmitterProcessor
  • Fix invalid json causing a reconnect

Which issue(s) this PR fixes:

Special notes for your reviewer:

Checklist

  • Documentation added
  • Tests updated

@steven-sheehy steven-sheehy added bug Type: Something isn't working P1 grpc Area: GRPC API labels Jul 11, 2020
@steven-sheehy steven-sheehy added this to the Mirror 0.15.0 milestone Jul 11, 2020
@steven-sheehy steven-sheehy requested a review from Nana-EC July 11, 2020 18:30
@steven-sheehy steven-sheehy self-assigned this Jul 11, 2020
@Nana-EC Nana-EC marked this pull request as ready for review July 12, 2020 01:17
Nana-EC
Nana-EC approved these changes Jul 12, 2020
View reviewed changes
Copy link
Contributor

@Nana-EC Nana-EC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@steven-sheehy steven-sheehy merged commit 6a43e2d into master Jul 12, 2020
@steven-sheehy steven-sheehy deleted the notify-fixes branch July 12, 2020 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nana-EC Nana-EC Nana-EC approved these changes

Assignees

@steven-sheehy steven-sheehy

Labels
bug Type: Something isn't working grpc Area: GRPC API P1
Projects
None yet
Milestone
Mirror 0.15.0
Development

Successfully merging this pull request may close these issues.
2 participants
@steven-sheehy @Nana-EC