Followup of #817 #824
Merged
Followup of #817 #824
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apeksharma
force-pushed
the
denorm_followup
branch
from
b2854de to
0810e19
Compare
2 tasks
apeksharma
force-pushed
the
denorm_followup
branch
from
0810e19 to
bf75af6
Compare
Signed-off-by: Apekshit Sharma <[email protected]>
apeksharma
force-pushed
the
denorm_followup
branch
from
bf75af6 to
be218a0
Compare
steven-sheehy
requested changes
Jun 12, 2020
...rror-importer/src/main/java/com/hedera/mirror/importer/exception/InvalidEntityException.java
Outdated
Show resolved
Hide resolved
.../src/main/java/com/hedera/mirror/importer/parser/record/entity/EntityRecordItemListener.java
Outdated
Show resolved
Hide resolved
...ter/src/main/java/com/hedera/mirror/importer/parser/record/entity/sql/SqlEntityListener.java
Outdated
Show resolved
Hide resolved
Nana-EC
previously approved these changes
Jun 12, 2020
Signed-off-by: Apekshit Sharma <[email protected]>
apeksharma
force-pushed
the
denorm_followup
branch
from
bd997f6 to
d8d1be4
Compare
steven-sheehy
approved these changes
Jun 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Detailed description:
LongtoEntityIdinTransactionandEntities. AddedEntityIdConverterfor the same.idfield in EntityId forEqualsAndHashCodesince that is sufficientSigned-off-by: Apekshit Sharma [email protected]
Which issue(s) this PR fixes:
Fixes #570
Part of #820
Special notes for your reviewer:
Checklist