Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HIP-551: Add batch transaction design #10481

Merged
merged 10 commits into from
Feb 28, 2025

Conversation

jnels124
Copy link
Contributor

@jnels124 jnels124 commented Feb 24, 2025

Description:
This pr will add the design document for the implementation of HIP-551

Related issue(s):

Fixes #10161

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@jnels124 jnels124 added the enhancement Type: New feature label Feb 24, 2025
@jnels124 jnels124 added this to the 0.125.0 milestone Feb 24, 2025
@jnels124 jnels124 self-assigned this Feb 24, 2025
@jnels124 jnels124 linked an issue Feb 24, 2025 that may be closed by this pull request
Copy link

codecov bot commented Feb 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

see 143 files with indirect coverage changes

@jnels124 jnels124 force-pushed the 10161-hip-551-design-batch-transactions branch from a954eff to 42e448e Compare February 24, 2025 20:21
@jnels124 jnels124 marked this pull request as ready for review February 24, 2025 20:28
@jnels124 jnels124 requested a review from a team as a code owner February 24, 2025 20:28
@jnels124 jnels124 changed the title add batch transaction design Add batch transaction design Feb 24, 2025
@jnels124 jnels124 marked this pull request as draft February 24, 2025 22:10
@jnels124 jnels124 marked this pull request as ready for review February 24, 2025 22:39
Signed-off-by: Jesse Nelson <[email protected]>
@jnels124 jnels124 force-pushed the 10161-hip-551-design-batch-transactions branch from a6b31e3 to e176874 Compare February 24, 2025 22:56
Signed-off-by: Jesse Nelson <[email protected]>
steven-sheehy
steven-sheehy previously approved these changes Feb 26, 2025
Copy link
Contributor

@steven-sheehy steven-sheehy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Jesse Nelson <[email protected]>
edwin-greene
edwin-greene previously approved these changes Feb 27, 2025
Copy link
Contributor

@edwin-greene edwin-greene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

steven-sheehy
steven-sheehy previously approved these changes Feb 27, 2025
@jnels124 jnels124 dismissed stale reviews from steven-sheehy and edwin-greene via 0adfa57 February 28, 2025 20:29
Signed-off-by: Jesse Nelson <[email protected]>
Copy link
Contributor

@xin-hedera xin-hedera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jnels124 jnels124 merged commit 612d65e into main Feb 28, 2025
30 of 32 checks passed
@jnels124 jnels124 deleted the 10161-hip-551-design-batch-transactions branch February 28, 2025 21:15
@steven-sheehy steven-sheehy changed the title Add batch transaction design HIP-551: Add batch transaction design Mar 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Type: New feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HIP-551: Design batch transactions
4 participants