Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix contract storage readable kv state slot values #10480

Merged
merged 2 commits into from
Feb 25, 2025
Merged

Fix contract storage readable kv state slot values #10480

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7050f78
fix: Fix contract storage readable kv state slot values
kselveliev Feb 24, 2025
96f17d3
fix: Addressing review comments
kselveliev Feb 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion ...3/src/main/java/com/hedera/mirror/web3/state/keyvalue/ContractStorageReadableKVState.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,8 @@

package com.hedera.mirror.web3.state.keyvalue;

import static com.hedera.mirror.common.util.DomainUtils.leftPadBytes;

import com.hedera.hapi.node.state.contract.SlotKey;
import com.hedera.hapi.node.state.contract.SlotValue;
import com.hedera.mirror.web3.common.ContractCallContext;
Expand All @@ -24,6 +26,7 @@
import com.hedera.services.utils.EntityIdUtils;
import jakarta.annotation.Nonnull;
import jakarta.inject.Named;
import org.apache.tuweni.bytes.Bytes32;

@Named
public class ContractStorageReadableKVState extends AbstractReadableKVState<SlotKey, SlotValue> {
Expand All @@ -49,7 +52,8 @@ protected SlotValue readFromDataSource(@Nonnull SlotKey slotKey) {
return timestamp
.map(t -> contractStateRepository.findStorageByBlockTimestamp(entityId, keyBytes, t))
.orElse(contractStateRepository.findStorage(entityId, keyBytes))
.map(byteArr -> new SlotValue(Bytes.wrap(byteArr), Bytes.EMPTY, Bytes.EMPTY))
.map(byteArr ->
new SlotValue(Bytes.wrap(leftPadBytes(byteArr, Bytes32.SIZE)), Bytes.EMPTY, Bytes.EMPTY))
.orElse(null);
}
}
4 changes: 3 additions & 1 deletion ...c/test/java/com/hedera/mirror/web3/state/keyvalue/ContractStorageReadableKVStateTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@

package com.hedera.mirror.web3.state.keyvalue;

import static com.hedera.mirror.common.util.DomainUtils.leftPadBytes;
import static org.assertj.core.api.AssertionsForClassTypes.assertThat;
import static org.mockito.ArgumentMatchers.any;
import static org.mockito.ArgumentMatchers.anyLong;
Expand All @@ -33,6 +34,7 @@
import com.hedera.pbj.runtime.io.buffer.Bytes;
import java.util.Collections;
import java.util.Optional;
import org.apache.tuweni.bytes.Bytes32;
import org.junit.jupiter.api.AfterAll;
import org.junit.jupiter.api.BeforeAll;
import org.junit.jupiter.api.BeforeEach;
Expand All @@ -49,7 +51,7 @@ class ContractStorageReadableKVStateTest {

private static final ContractID CONTRACT_ID =
new ContractID(1L, 0L, new OneOf<>(ContractOneOfType.CONTRACT_NUM, 1L));
private static final Bytes BYTES = Bytes.fromBase64("123456");
private static final Bytes BYTES = Bytes.wrap(leftPadBytes("123456".getBytes(), Bytes32.SIZE));
private static final SlotKey SLOT_KEY = new SlotKey(CONTRACT_ID, BYTES);
private static final EntityId ENTITY_ID =
EntityId.of(CONTRACT_ID.shardNum(), CONTRACT_ID.realmNum(), CONTRACT_ID.contractNum());
Expand Down
Loading