Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add id for SGScript entries #10453

Merged
merged 2 commits into from
Feb 21, 2025
Merged

Add id for SGScript entries #10453

merged 2 commits into from
Feb 21, 2025

Conversation

jnels124
Copy link
Contributor

Description:

Related issue(s):

Fixes #

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

Signed-off-by: Jesse Nelson <[email protected]>
@jnels124 jnels124 requested a review from a team as a code owner February 21, 2025 19:59
@jnels124 jnels124 marked this pull request as draft February 21, 2025 20:03
@steven-sheehy steven-sheehy added this to the 0.124.1 milestone Feb 21, 2025
@steven-sheehy steven-sheehy added the bug Type: Something isn't working label Feb 21, 2025
Copy link

codecov bot commented Feb 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Signed-off-by: Jesse Nelson <[email protected]>
@jnels124 jnels124 marked this pull request as ready for review February 21, 2025 22:48
Copy link
Contributor

@edwin-greene edwin-greene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@jnels124 jnels124 merged commit 5e86962 into main Feb 21, 2025
34 checks passed
@jnels124 jnels124 deleted the jtn-124-fix branch February 21, 2025 22:53
jnels124 added a commit that referenced this pull request Feb 21, 2025
add id for SGScript entries

---------

Signed-off-by: Jesse Nelson <[email protected]>
(cherry picked from commit 5e86962)
Signed-off-by: Jesse Nelson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Type: Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants