Fix ContractCallEvmCodesHistoricalTest tests
#10380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bilyana Gospodinova <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10380 +/- ##
============================================
- Coverage 92.19% 92.18% -0.01%
Complexity 8108 8108
============================================
Files 989 989
Lines 33755 33755
Branches 4267 4267
============================================
- Hits 31120 31117 -3
- Misses 1619 1620 +1
- Partials 1016 1018 +2 ☔ View full report in Codecov by Sentry. |
|
steven-sheehy
approved these changes
Feb 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR fixes the setup of the
ContractCallEvmCodesHistoricalTesttests - they were failing with themodularizedServicesflag set totrue. The historical sender in the class clashed with the inherited setup from the parent classes.Fixes https://github.com/hashgraph/hedera-mirror-node/issues/10078