Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ContractCallServicePrecompileHistoricalTest tests #10363

Merged
merged 1 commit into from
Feb 12, 2025

Conversation

bilyana-gospodinova
Copy link
Contributor

Description:
This PR fixes the failing tests in the ContractCallServicePrecompileHistoricalTest suite with the modularizedServices flag set to true. The changes are just in adapting the test setup.

Fixes https://github.com/hashgraph/hedera-mirror-node/issues/10086

@bilyana-gospodinova bilyana-gospodinova added enhancement Type: New feature web3 Area: Web3 API labels Feb 12, 2025
@bilyana-gospodinova bilyana-gospodinova self-assigned this Feb 12, 2025
Copy link

codecov bot commented Feb 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.26%. Comparing base (a714e00) to head (054ac73).
Report is 1 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main   #10363      +/-   ##
============================================
+ Coverage     92.16%   92.26%   +0.10%     
+ Complexity     8050     7948     -102     
============================================
  Files           986      968      -18     
  Lines         33579    33322     -257     
  Branches       4243     4221      -22     
============================================
- Hits          30947    30744     -203     
+ Misses         1619     1570      -49     
+ Partials       1013     1008       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bilyana-gospodinova bilyana-gospodinova marked this pull request as ready for review February 12, 2025 11:57
@bilyana-gospodinova bilyana-gospodinova requested a review from a team as a code owner February 12, 2025 11:57
@steven-sheehy steven-sheehy added this to the 0.124.0 milestone Feb 12, 2025
@steven-sheehy steven-sheehy merged commit a5646b2 into main Feb 12, 2025
35 of 36 checks passed
@steven-sheehy steven-sheehy deleted the 10086-contract-call-precompile-historical-tests branch February 12, 2025 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Type: New feature web3 Area: Web3 API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix ContractCallServicePrecompileHistoricalTest test suite
3 participants