Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return only the current address book from state proof alpha REST API #1029

Merged
merged 1 commit into from
Sep 10, 2020

Conversation

steven-sheehy
Copy link
Contributor

Detailed description:

Which issue(s) this PR fixes:

Special notes for your reviewer:

Checklist

  • Documentation added
  • Tests updated

…1018)

- Update state proof alpha REST API to only return the address book at the time of the queried transaction
- Update test data and integration test spec to validate the change
- Update design doc

Signed-off-by: Xin Li <[email protected]>
@steven-sheehy steven-sheehy added enhancement Type: New feature P1 rest Area: REST API labels Sep 10, 2020
@steven-sheehy steven-sheehy self-assigned this Sep 10, 2020
Copy link
Contributor

@xin-hedera xin-hedera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Sep 10, 2020

Codecov Report

Merging #1029 into release/0.18 will increase coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@                Coverage Diff                 @@
##             release/0.18    #1029      +/-   ##
==================================================
+ Coverage           86.52%   86.58%   +0.05%     
- Complexity            210      211       +1     
==================================================
  Files                 176      176              
  Lines                4386     4389       +3     
  Branches              494      495       +1     
==================================================
+ Hits                 3795     3800       +5     
+ Misses                438      437       -1     
+ Partials              153      152       -1     
Impacted Files Coverage Δ Complexity Δ
...r/importer/config/MetricsExecutionInterceptor.java 82.35% <0.00%> (-1.48%) 0.00% <0.00%> (ø%)
stateproof.js 95.91% <0.00%> (+0.12%) 0.00% <0.00%> (ø%)
...irror/importer/parser/record/RecordFileParser.java 90.52% <0.00%> (+1.05%) 0.00% <0.00%> (ø%)
...rror/grpc/listener/SharedPollingTopicListener.java 96.49% <0.00%> (+3.50%) 11.00% <0.00%> (+1.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c96f1d2...e41b7dd. Read the comment docs.

@steven-sheehy steven-sheehy merged commit 04ad022 into release/0.18 Sep 10, 2020
@steven-sheehy steven-sheehy deleted the port-address-book-fix branch September 10, 2020 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Type: New feature P1 rest Area: REST API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants