Fix contract call ERC modification approve tests #10210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bilyana Gospodinova <[email protected]>
Signed-off-by: Bilyana Gospodinova <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10210 +/- ##
=========================================
Coverage 92.23% 92.23%
Complexity 7942 7942
=========================================
Files 971 971
Lines 33231 33231
Branches 4180 4180
=========================================
Hits 30649 30649
Misses 1598 1598
Partials 984 984 ☔ View full report in Codecov by Sentry. |
|
steven-sheehy
approved these changes
Jan 23, 2025
kselveliev
approved these changes
Jan 23, 2025
steven-sheehy
deleted the
010084-contract-call-erc-modification-tests-approve
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Fix the
approve*tests in ERC test suite. Also, a slight refactoring was made - extract common hollow account creation logic in a separate method.Fixes #10084