Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix transfer* tests in ContractCallServiceERCTokenModificationFunctionsTest #10199

Merged
merged 1 commit into from
Jan 22, 2025

Conversation

bilyana-gospodinova
Copy link
Contributor

@bilyana-gospodinova bilyana-gospodinova commented Jan 22, 2025

Description:
This PR fixes transfer* tests with the modularizedServices flag == true (except transferFromToHollowAccount() where there is some state issue that occurs in other tests too).

Refactored the class to remove one method (accountPersist()) that was similar in a parent class.

Related issue(s): https://github.com/hashgraph/hedera-mirror-node/issues/10084

@bilyana-gospodinova bilyana-gospodinova added enhancement Type: New feature web3 Area: Web3 API labels Jan 22, 2025
@bilyana-gospodinova bilyana-gospodinova self-assigned this Jan 22, 2025
Copy link

codecov bot commented Jan 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.30%. Comparing base (940eef0) to head (2eb3c64).
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main   #10199   +/-   ##
=========================================
  Coverage     92.30%   92.30%           
  Complexity     7826     7826           
=========================================
  Files           949      949           
  Lines         32883    32883           
  Branches       4153     4153           
=========================================
  Hits          30353    30353           
  Misses         1554     1554           
  Partials        976      976           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bilyana-gospodinova bilyana-gospodinova marked this pull request as ready for review January 22, 2025 12:29
@bilyana-gospodinova bilyana-gospodinova requested a review from a team as a code owner January 22, 2025 12:29
@bilyana-gospodinova bilyana-gospodinova changed the title Fix transfer* tests in ContractCallServiceERCTokenModificationFunctionsTest Fix transfer* tests in ContractCallServiceERCTokenModificationFunctionsTest Jan 22, 2025
@steven-sheehy steven-sheehy added this to the 0.122.0 milestone Jan 22, 2025
@steven-sheehy steven-sheehy merged commit 798b040 into main Jan 22, 2025
36 checks passed
@steven-sheehy steven-sheehy deleted the 010084-contract-call-erc-modification-tests branch January 22, 2025 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Type: New feature web3 Area: Web3 API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants