Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the failing tests in InternalCallsTest #10156

Merged
merged 3 commits into from
Jan 17, 2025

Conversation

bilyana-gospodinova
Copy link
Contributor

Description:
Adapt the failing tests in InternalCallsTest. There is a difference in the behaviour in the mono code and the modularized code, so depending on the modularizedServices flag the test assertions are different.

Fixes #10089

@bilyana-gospodinova bilyana-gospodinova added enhancement Type: New feature web3 Area: Web3 API labels Jan 17, 2025
@bilyana-gospodinova bilyana-gospodinova self-assigned this Jan 17, 2025
@bilyana-gospodinova bilyana-gospodinova force-pushed the 010089-fix-internal-calls-test branch from baee0f2 to 74e8b22 Compare January 17, 2025 15:45
Signed-off-by: Bilyana Gospodinova <[email protected]>
@bilyana-gospodinova bilyana-gospodinova marked this pull request as ready for review January 17, 2025 16:06
@bilyana-gospodinova bilyana-gospodinova requested a review from a team as a code owner January 17, 2025 16:06
@steven-sheehy steven-sheehy added this to the 0.122.0 milestone Jan 17, 2025
Signed-off-by: Bilyana Gospodinova <[email protected]>
Copy link

codecov bot commented Jan 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.30%. Comparing base (468fec2) to head (5ae2d2a).
Report is 2 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main   #10156      +/-   ##
============================================
- Coverage     92.31%   92.30%   -0.01%     
  Complexity     7821     7821              
============================================
  Files           947      947              
  Lines         32846    32846              
  Branches       4151     4151              
============================================
- Hits          30321    30320       -1     
  Misses         1550     1550              
- Partials        975      976       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@steven-sheehy steven-sheehy merged commit 90540c5 into main Jan 17, 2025
36 checks passed
@steven-sheehy steven-sheehy deleted the 010089-fix-internal-calls-test branch January 17, 2025 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Type: New feature web3 Area: Web3 API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix InternalCallsTest test suite
2 participants