Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mirror node assumes running from day 0 #101

Closed
gregscullard opened this issue Aug 27, 2019 · 1 comment
Closed

Mirror node assumes running from day 0 #101

gregscullard opened this issue Aug 27, 2019 · 1 comment
Labels
bug Type: Something isn't working P2 parser Area: File parsing
Milestone
0.1.0

Comments

@gregscullard
Copy link
Contributor

The current code surrounding entities assumes that data for a network is being parsed from day 0 resulting in an assumption that an entity will exist in the database when a transaction to update, delete, systemDelete or systemUndelete this entity occurs.

However, since mirror node will not parse data from day 0, it is necessary to check whether an entity indeed exists prior to attempting and update or deletion.
@gregscullard gregscullard mentioned this issue Aug 27, 2019
Merged
mike-burrage-hedera added a commit that referenced this issue Aug 27, 2019
@mike-burrage-hedera
Merge pull request #97 from hashgraph/fix/recordLogBugFixes
b50ded3 
Fix/record log bug fixes - Addresses #101
@mike-burrage-hedera
Copy link
Contributor

Fixed in #97

@steven-sheehy steven-sheehy added this to the 0.1.0 milestone Aug 27, 2019
@steven-sheehy steven-sheehy added bug Type: Something isn't working P2 parser Area: File parsing labels Nov 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Type: Something isn't working P2 parser Area: File parsing
Projects
None yet
Milestone
0.1.0
Development

No branches or pull requests
3 participants
@gregscullard @steven-sheehy @mike-burrage-hedera