-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
7810 spl token gating #7833
7810 spl token gating #7833
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
![image](https://private-user-images.githubusercontent.com/14819225/330762192-b43e5125-f527-498a-954c-80642b5dc6e5.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk1NjE1MjUsIm5iZiI6MTczOTU2MTIyNSwicGF0aCI6Ii8xNDgxOTIyNS8zMzA3NjIxOTItYjQzZTUxMjUtZjUyNy00OThhLTk1NGMtODA2NDJiNWRjNmU1LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTQlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjE0VDE5MjcwNVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTc3ZGEzYTAzZThjZmQ5OTVmZGVmYTc3MmI2YTllY2M1MzNkNzE1MWZiOTc3OGVhZmViZTAwOWQyZTlhNjgwNjEmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.H9c5DzhRZ5ZxtrRrRFKEakvdpb1z5D__MX0PTn4VMFQ)
Not sure if this is the issue for this PR but I am not able to sign in with phantom wallet. Getting error in the console when I click the button in our login modal.
Generally, front end looks good to me, but would like @mzparacha to take a look at that, as he worked on the groups more closely
packages/commonwealth/client/scripts/views/pages/CommunityGroupsAndMembers/common/constants.ts
Show resolved
Hide resolved
...s/commonwealth/client/scripts/views/pages/CreateCommunity/steps/CommunityTypeStep/helpers.ts
Show resolved
Hide resolved
@masvelio I believe this is expected behavior(which I just learned) - the active community query that creates the community list only includes communities with > 10 addresses or with community stake enabled |
ooh got ya, thanks for clarification |
libs/model/src/services/tokenBalanceCache/providers/getSolanaBalances.ts
Outdated
Show resolved
Hide resolved
libs/model/src/services/tokenBalanceCache/providers/getSolanaBalances.ts
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
G2G
Link to Issue
Closes: #7833
Description of Changes
Test Plan
run migration and yarn
sign-in with Phantom Wallet
Make yourself admin of the solana community via DB
create requirements with the following sample tokens(note sol isnt prefiex with 0x's) using Solana Mainnet Beta
got to the members tab and note that some addresses are included in each group filter
Set a high value for WIF(ie 1000000) and note that some should not be in group any more
Additionally test other chain groups(ie evm) to ensure these changes don't create issues/regressions
Deployment Plan
Other Considerations