Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contributions by Liz Bravo #138

Closed
lizbravob opened this issue Mar 8, 2020 · 58 comments
Closed

Contributions by Liz Bravo #138

lizbravob opened this issue Mar 8, 2020 · 58 comments

Comments

@lizbravob
Copy link
Contributor

lizbravob commented Mar 8, 2020

Hi, again.
I drew others missing openmoji.
#pickup
#olive
#worm
#fly
#disguisedface
#smilingfacewithtear

I wait for your feedback
Greetings ✌🏻
Openmoji_lizbravob.zip

@carlinmack
Copy link
Contributor

😮 amazing! We're still to add your others but thanks for the work!

@carlinmack
Copy link
Contributor

image
perfect

image
perfect

image
perfect

image
pinging @b-g

image
I think the wings and body should be rounder,

image
so cool

image
pinging @b-g

@b-g b-g mentioned this issue Mar 9, 2020
65 tasks
@b-g
Copy link
Member

b-g commented Mar 9, 2020

Hi @lizbravob! Mega! Very nice! Looks great in general! Just two comments:

  • The olive looks quite flat (thought first it is an avocado), could you try to give it a shadow to make it look more rounded/3d? See styleguide https://openmoji.org/styleguide/

Screenshot 2020-03-09 at 15 46 37

  • Fly is fine for me ... it might have a bit more details than the other OpenMoji insects (https://openmoji.org/library/#search=insect), so a bit less details might be better ... but up to you

  • I think the worm should not be shaped like the letter S e.g. see the shape of the work of https://emojipedia.org/worm/. I personally like the one without the full outline better ... but up to you.

Could you look once more into it?

Would then add all you great contributions mid/end of the week ...

🙏👍

@carlinmack
Copy link
Contributor

@b-gjust to let you know I'm going to add Bravo's emojis on the Emoji13 branch tonight :) I think it's best to keep them separated until emojibase updates

@carlinmack
Copy link
Contributor

added Pickup, Disguised Face and Smiling with Tear here d348d2a, will keep open for further work on the other emojis

@b-g b-g changed the title Others missing openmoji Contributions by Liz Bravo Mar 10, 2020
@lizbravob
Copy link
Contributor Author

Hola!!

Thank you for the feedback. I'll fix the others🤘🏻
Have a nice day!

@lizbravob
Copy link
Contributor Author

lizbravob commented Mar 11, 2020

I fix it! :)
Openmoji_lizbravob.zip

#1F6FC #1FA84 #1FA86 #1FA74 #1FAA5 👍
Openmoji_lizbravo.zip

@carlinmack
Copy link
Contributor

image
great

image
great

image
I think this is now too round, go for this sort of silhouette: https://commons.wikimedia.org/wiki/File:Close-up_of_Chrysomya_(Old_World_blow_fly)_on_a_green_leaf.jpg? thanks :)

@carlinmack
Copy link
Contributor

carlinmack commented Mar 12, 2020

image
nice, maybe shading on the wheels, pinging @b-g

image
perfect!
edit: can you add a black stroke in a line-supplement layer behind the color layer? The symbol is ambiguous in the black only version https://github.com/hfg-gmuend/openmoji/blob/master/black/svg/1FA84.svg

See https://openmoji.org/styleguide/#special_layers for details :)
image
hmm... needs some work - doesn't look like the pieces connect, @b-g

image
good

image
great! please add white shape for the fill of the bristles

@b-g
Copy link
Member

b-g commented Mar 12, 2020

Hi @lizbravob, Wow!! Many thanks for the fixes and the new ones! 🙏

No much to add to @carlinmack feedback! To summarize:

Done

  • Olive ✅
  • Worm ✅
  • Roller Skaters ✅, fine for me ... would prefer as it is without any shading on the wheels

Open

Also this is dialog ... please feel free to disagree with us, we are happy to discuss things! :)

@b-g
Copy link
Member

b-g commented Mar 16, 2020

Hi @lizbravob! Hope you are staying healthy and sane in these wild times! This is just a quick heads up ... we are going to release OpenMoji v12.2 tomorrow. Hence if you want to have all your latest emojis shipped, then it would be good to have the revised ones soon :) If you have no time, no problem ... then it will go in the next release after. Both is fine.

@lizbravob
Copy link
Contributor Author

lizbravob commented Mar 17, 2020

Hi @b-g! Sorry for the delay, thank u for your comments, I hope I've improved the openmoji. If it needs more work I'm happy to correct.
Greetings, be safe!

Openmoji_lizbravo.zip

@carlinmack
Copy link
Contributor

image
looks great!

image
great!

image
good!

image
(deconstructed to show the line-supplement layer) great!

I'll add these all for the release tomorrow :)

@carlinmack
Copy link
Contributor

carlinmack commented Mar 17, 2020

magic wand doesn't render correctly in the new font :(
image

the svg-black is fine though
image

@b-g
Copy link
Member

b-g commented Mar 17, 2020

@lizbravob Many thanks + great! 🙏 I've just released everything (give the website 1h to update)

@carlinmack Yes the black font part is tricky ... and we are on it. But the magic wand should work in the colorfonts

@carlinmack
Copy link
Contributor

yeah not that big of a deal, just wanted to let you know, congrats on the release, it's been a long time coming haha

@carlinmack
Copy link
Contributor

https://openmoji.org/library/#author=Liz%20Bravo 😁

@lizbravob
Copy link
Contributor Author

Awesome!!! 🥰 Thank u!!

@lizbravob
Copy link
Contributor Author

Hi, I'm working in more openmoji because I'm in quarantine to covid-19 :( a day, an openmoji jaja.

I submit all in 14 days or do you prefer to see one by one?

Greetings, BE SAFE!

@carlinmack
Copy link
Contributor

you can submit every day, I'm also quarantined with not a lot to do, happy to review them :)

@lizbravob
Copy link
Contributor Author

Great! :)
Openmoji_LizBravo.zip

@carlinmack
Copy link
Contributor

carlinmack commented Mar 22, 2020

image

  • the trap should be a brown colour
  • the bar should be silver
  • change the vertical bar that goes from the top to the cheese
    image

image
perfect

image
can you try one with the handle above the bucket?

image
I'm not sure about the precedence for this but maybe lose the stroke on the bottom? as it should appear to be in the ground @b-g ?

image
good

carlinmack added a commit that referenced this issue Mar 24, 2020
@carlinmack
Copy link
Contributor

btw could you make sure that the emojis are at least the size of the circle, we don't want the emojis to be too small!

@b-g
Copy link
Member

b-g commented Mar 26, 2020

Hi @lizbravob, many thanks for the nice new ones! Sorry for the slow feedback ... but busy dealing and juggling corona related issues on all ends. Anyway here's some additional feedback (after a meeting with @dnlutz):

  • mouse trap, we think a flat one will be really difficult. Hence we would suggest to go rather in a 3d direction. It's fine to do exceptions if it really makes the emojis way better in terms of readability, see https://openmoji.org/styleguide/#perspective e.g. https://openmoji.org/library/#search=books, https://openmoji.org/library/#search=dice ... here is also a quick sketch
    IMG_3649
  • plunge: great!
  • bucket: great, but yes it would be interesting to see a version with the handle above the bucket
  • headstone: to be honest I first thought this is a proposal for a (knight) military helmet. Could you "ground" it better and hint e.g. ground, vegetation, soil ...? See https://emojipedia.org/headstone/
  • placard: nice! But I think the two lines representing text could be improved to something a bit more regular, and both lines should be different. Now one could also read it as (water) "waves".

Very nice work!

@lizbravob
Copy link
Contributor Author

Hi @b-g & @carlinmack I'm thankful for your feedback :) trying to improve openmoji during coronavirus!
Openmoji_lizbravob.zip

@carlinmack
Copy link
Contributor

bitmap
Can't believe I never thought of just making an SVG and exporting it lol!

  1. I think I prefer this bucket
  2. I like the boomarang
  3. very pretty
  4. I'd make the bottom end of the thread a bit longer
  5. much better!
  6. I think the trap mechanism is too difficult to see, maybe all grey or switch to black?
  7. I think both these mirrors
  8. are very funky
  9. alright
  10. I prefer this one because I like how looks like the handwritten signs you see at protests

@b-g
Copy link
Member

b-g commented Apr 14, 2020

+1! Nice plant and I also liken the grey hook better! Great!

@lizbravob
Copy link
Contributor Author

lizbravob commented May 29, 2020

Hi 👋
I have been working in more openmoji.

openmoji_lizbravob.zip

Nice weekend :)

@dnlutz
Copy link
Contributor

dnlutz commented May 30, 2020

1F9CB Bubble Tea
O.k. … I first had to google what the black dots actually are ; ) What about reducing the number of pearls and placing them in a more "organic / random" ways?
The cup looks quite edgy, maybe you could round off the bottom a little bit? The straw with a bend?

1FA9F Window
I got it wrong, it seemed to be a glass door (sorry ; )
I would try a more simple design, maybe like the one from twitter: https://emojipedia.org/window/
I like the two white lines as reflection, but i think it will be better if it is more extensive. There is a good example in our styleguide (which is not online yet) > check out the smartphone at the botton. Would that be an option?
guideline_shadow.pdf

1FA97 Accordion
Beautiful! The only thing I would change around here to simplify it a little bit: two or three segments less in the middle?

1FAD1 Bell pepper
Here I would pull the shadow all the way up to cover the whole right third (like the skull in the guideline example above.

1FAD5 Fondue
The pot maybe a bit higher? … and you could take a skewer out and let some cheese run down to make it clearer ; )

1FAD6 Teapot
Nice! Maybe a bit less traditional and more geometric?

Overall: great work, thank you very much!
Have a nice weekend (I hope you also have a bank holiday on Monday ; )

@carlinmack
Copy link
Contributor

I much prefer this as a more geometric teapot design https://commons.wikimedia.org/wiki/File:Tea_pot,_Downpatrick,_September_2010.JPG however I do like the traditional version you originally used

@carlinmack
Copy link
Contributor

image
I think this is an improvement

@b-g
Copy link
Member

b-g commented Jul 20, 2020

Hi @lizbravob, Hope this message finds you all well! We have the next OpenMoji release coming up (before we go into a long summer break)! Any chance to get your open ones in the enxt days/weeks? Sorry to bother :)

@lizbravob
Copy link
Contributor Author

Hi @b-g sorry, I forgot to submit the openmoji, but they are here with the corrections :) thanks for the feedback @dnlutz 🚀
If there any correction, I'll be pending.

Openmoji_lizbravob.zip

@b-g
Copy link
Member

b-g commented Jul 21, 2020

Hi @lizbravob, great + many thanks! Will add them all asap!

Only comment: I don't fully get the sign on the coin 1FA99? Would a "1" or/and a silhouette of a person not be more universal? See https://emojipedia.org/coin/

2020-07-21 at 08 42

@lizbravob
Copy link
Contributor Author

lizbravob commented Jul 21, 2020

Sure, like this one?

1FA99.zip

@b-g
Copy link
Member

b-g commented Jul 21, 2020

Great + 🙏! Added all of them to the library with the latest commit.

@lizbravob
Copy link
Contributor Author

Hi, I was working on the latest openmoji v13 while you were off, hope it works fine, enjoy doing.

I have a doubt respect the person color if I have to make a different openmoji with each skin tone & I don't know which code corresponds. Well, I'll wait for your comments.

Have a good weekend.
Greetings
openmoji_lizbravob.zip

@carlinmack
Copy link
Contributor

Wow these are all great, thanks!

image

We'll add them in October :)

@dnlutz
Copy link
Contributor

dnlutz commented Sep 29, 2020

very nice work, thank you!
i especially like the mammoth, the bison and the seal!

here are my suggestions:
1f9a4: what about simplifying the wings?
1f9ab: the beaver looks a bit anxious. what about making it a bit more upright? … and it should be well distinguishable from an ordinary squirrel.
1F977: i would rather design the ninja like a person and not like a smiley (like the others)
1faa2: very nice knotted ; )
1faa8: maybe it is a little bit too big? and could yo u please try to simplify it a little bit? (all our mountains are a bit tool complicated by the way)

@lizbravob
Copy link
Contributor Author

Hi, @dnlutz Thanks for your feedback.

I'll give them another spin regarding your suggestions 👍

@hfg-gmuend hfg-gmuend deleted a comment from github-actions bot Oct 1, 2020
@hfg-gmuend hfg-gmuend deleted a comment from github-actions bot Oct 1, 2020
@hfg-gmuend hfg-gmuend deleted a comment from github-actions bot Oct 1, 2020
@hfg-gmuend hfg-gmuend deleted a comment from github-actions bot Oct 1, 2020
@lizbravob
Copy link
Contributor Author

Holaa 👋
I remade some openmoji :)

openmojii_lizbravob.zip

Grettings

@carlinmack
Copy link
Contributor

image

all great! you are a star 🌟

@dnlutz
Copy link
Contributor

dnlutz commented Oct 8, 2020

yes, looks great!

@b-g
Copy link
Member

b-g commented Oct 8, 2020

Hi @lizbravob Wow! Mega nice! Thank you so much!

@carlinmack
Copy link
Contributor

alright, I'm adding them all today 💪

@lizbravob
Copy link
Contributor Author

Awesome!! You Rock 🤘🏻🔥

@carlinmack
Copy link
Contributor

I think we're missing two actually that I didn't realise and list previously, man with veil and woman in tuxedo

@b-g
Copy link
Member

b-g commented Oct 30, 2020

@lizbravob could you also design the remaining last two ones (man with veil and woman in tuxedo)?

@lizbravob
Copy link
Contributor Author

Hi, @b-g sure!

What do you think about this? can it work?
missing_openmoji.zip

I don't know the hexcode :(

Greetings

@carlinmack
Copy link
Contributor

image
looks great! I'll add it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants