-
-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: drop Node 6 #3598
chore: drop Node 6 #3598
Conversation
Some considerations:
|
I think maybe no.
I prefer to create a branch by new version. But, hexo team seems has never created new branch. (Sorry I'm not familiar with hexo team development flow) IMO, we can merge this PR to master. Because, maybe we will not release a patch version. |
I think maybe it's better to upgrade eslint-config-hexo. @segayuu |
can someone restart the appveyor build with cleared cache? |
How about re-commit & force-push? |
@yoshinorin |
I created a new PR for eslint-config-hexo (hexojs/eslint-config-hexo#16). |
This reverts commit d92195c.
disable then re-enable cache works. Remember to squash them though. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
* chore: drop Node 6 hexojs#3508
What does it do?
Drop Node 6 as per #3508 . It has reached EOL since 2019-04-30.
How to test
Pull request tasks