Fix default server config to listen on both IPv4 and IPv6 #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit is a fix following the PR hexojs#39. This PR changed the default behavior of the server to listen on all interfaces (both IPv4 and IPv6). This commit was missing the update of the default configuration, causing the server to still listen only to IPv4 by default. The current commit fixes this error by using `undefined` (Node's default) for the IP. - See hexojs#35 - See hexojs#39
1 similar comment
|
Thanks. Could you bump the version to |
|
@NoahDragon |
|
@demurgos will do it soon. Just back from vacation. |
|
It's on NPM now. |
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit is a fix following the PR #39. This PR changed the
default behavior of the server to listen on all interfaces (both
IPv4 and IPv6). This commit was missing the update of the default
configuration, causing the server to still listen only to IPv4 by
default. The current commit fixes this error by using
undefined(Node's default) for the IP.
As opposed to #39, this PR should be considered as a patch
(for the semver version) because the change of the default was
already documented for the version
0.3.0.